[Autotest failure] network_WiFi_AttenuatedPerf failing with "Telnet command failed to return valid data." |
|||||||||
Issue description
Randomly fails on some calls to set attenuation.
08/20 12:17:12.172 WARNI| test:0606| The test failed with the following exception
Traceback (most recent call last):
File "/usr/local/autotest/client/common_lib/test.py", line 600, in _exec
_call_test_function(self.execute, *p_args, **p_dargs)
File "/usr/local/autotest/client/common_lib/test.py", line 800, in _call_test_function
return func(*args, **dargs)
File "/usr/local/autotest/client/common_lib/test.py", line 464, in execute
postprocess_profiled_run, args, dargs)
File "/usr/local/autotest/client/common_lib/test.py", line 371, in _call_run_once
self.run_once(*args, **dargs)
File "/usr/local/autotest/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py", line 87, in run_once
atten, self._ap_config.frequency)
File "/usr/local/autotest/server/cros/network/attenuator_controller.py", line 164, in set_total_attenuation
attenuator_num=atten)
File "/usr/local/autotest/server/cros/network/attenuator_controller.py", line 180, in set_variable_attenuation
self._attenuator.set_atten(atten, atten_db)
File "/usr/local/autotest/server/cros/network/attenuator.py", line 76, in set_atten
(channel + 1, value))) != 1):
File "/usr/local/autotest/server/cros/network/telnet_helper.py", line 82, in cmd
"Data returned: %s" % ret_text)
TestError: Telnet command failed to return valid data. Data returned:
,
Aug 24
Telnet commands fails to return valid data. We use to see this error sometimes prior to Aug 10 but since then failures resulting from this has spiked. The issue seems to be with telnet connection that we create though the connection remains open, we stop receiving expected data using telnet expect. This seems to get worse with large number of telnet calls. Closing and reopening telnet connection fixes the issue. https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1188984
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bd17064216b4a299b52cc7951e326008bf23d68b commit bd17064216b4a299b52cc7951e326008bf23d68b Author: harpreet <harpreet@google.com> Date: Thu Aug 30 04:05:51 2018 autotest: network_WiFi_AttenuatorPerf - Fix multiple issues Fixing 3 issues that we have see on the attenuated (grover) setups in the lab. 1) Unhandled timeout when opening telnet connection ( crbug.com/854377 ) 2) TypeError for signal level. output_perf_value expects string or number but wifi_signal_level returns None if signal is not detected. This usually happens on runs with high attenuation ( crbug.com/854378 ) 3) Telnet commands fails to return valid data. We use to see this error sometimes prior to Aug 10 but since then failures resulting from this has spiked. The issue seems to be with telnet connection that we create though the connection remains open, we stop receiving expected data using telnet expect. This seems to get worse with large number of telnet calls. Closing and reopening telnet connection fixes the issue. ( crbug.com/876945 ) BUG= chromium:854377 , chromium:854378 , chromium:876945 TEST=Tested against eve in grover setup in wifi lab. Change-Id: Iccb711c59f29a216ea6a936c7757b4048fd0cc1c Reviewed-on: https://chromium-review.googlesource.com/1188984 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/attenuator.py [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/telnet_helper.py [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/attenuator_controller.py
,
Aug 30
,
Aug 30
,
Aug 30
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 31
Appears this has already been cherry picked into M69.
,
Aug 31
cindyb@ - not yet. I created the CL but its not merged yet. Was waiting for approval on this bug. https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1196769
,
Aug 31
Merge approved, M69. Tested on ToT, per chat.
,
Sep 4
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/45c8391e2a4b0cf2155230204d253a91ac763ab7 commit 45c8391e2a4b0cf2155230204d253a91ac763ab7 Author: harpreet <harpreet@google.com> Date: Mon Sep 10 18:40:43 2018 autotest: network_WiFi_AttenuatorPerf - Fix multiple issues Fixing 3 issues that we have see on the attenuated (grover) setups in the lab. 1) Unhandled timeout when opening telnet connection ( crbug.com/854377 ) 2) TypeError for signal level. output_perf_value expects string or number but wifi_signal_level returns None if signal is not detected. This usually happens on runs with high attenuation ( crbug.com/854378 ) 3) Telnet commands fails to return valid data. We use to see this error sometimes prior to Aug 10 but since then failures resulting from this has spiked. The issue seems to be with telnet connection that we create though the connection remains open, we stop receiving expected data using telnet expect. This seems to get worse with large number of telnet calls. Closing and reopening telnet connection fixes the issue. ( crbug.com/876945 ) BUG= chromium:854377 , chromium:854378 , chromium:876945 TEST=Tested against eve in grover setup in wifi lab. Change-Id: Iccb711c59f29a216ea6a936c7757b4048fd0cc1c Reviewed-on: https://chromium-review.googlesource.com/1188984 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> (cherry picked from commit bd17064216b4a299b52cc7951e326008bf23d68b) Reviewed-on: https://chromium-review.googlesource.com/1196769 Reviewed-by: Harpreet Grewal <harpreet@chromium.org> Commit-Queue: Harpreet Grewal <harpreet@chromium.org> Trybot-Ready: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/attenuator.py [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/telnet_helper.py [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/attenuator_controller.py
,
Sep 12
,
Sep 13
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by harpreet@chromium.org
, Aug 23