New issue
Advanced search Search tips

Issue 876940 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Folder text field's touch target resizes based on text size

Project Member Reported by ginko@chromium.org, Aug 23

Issue description

Chrome Version: 70.0.3523.0
OS: Chrome


What steps will reproduce the problem?
(1) create a folder
(2) rename to a single character (e.g. "i"
(3) attempt to tap to rename this folder

What is the expected result?
tapping anywhere in the default text field area should trigger the rename (perhaps anywhere along the bottom?

What happens instead?
you have to specifically tap the single character


Bonus video:
https://photos.app.goo.gl/C1UQKVhPnYgyhswX6


 
Labels: M-71 Pri-2
Owner: oxyflush@chromium.org
Status: Assigned (was: Untriaged)
Cc: newcomer@chromium.org ginko@chromium.org
 Issue 878165  has been merged into this issue.
Labels: intern-bug
Please take it from here, thanks!
Owner: newcomer@chromium.org
Owner: ----
Owner: ginko@chromium.org
Gosh.. Daniel didn't even try to do the bug I gave him... fiiiiiine. 
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c0ef1c7f3c7671b439d8a7882e80d505844b2b

commit 67c0ef1c7f3c7671b439d8a7882e80d505844b2b
Author: Kevin Strohbehn <ginko@google.com>
Date: Tue Sep 25 18:07:45 2018

Sets folder name touch target to one static size

Bug:  876940 
Change-Id: I3838f52b4f2501e488d4c4a9efeb08f1d26b81b4
Reviewed-on: https://chromium-review.googlesource.com/1242455
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#594006}
[modify] https://crrev.com/67c0ef1c7f3c7671b439d8a7882e80d505844b2b/ash/app_list/views/folder_header_view.cc
[modify] https://crrev.com/67c0ef1c7f3c7671b439d8a7882e80d505844b2b/ash/app_list/views/folder_header_view.h

Status: Fixed (was: Started)

Sign in to add a comment