New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876936 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Aug 27
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Try jobs for webkit_layout_test on WebKit Mac10.13 (retina) acting weirdly

Project Member Reported by chanli@chromium.org, Aug 23 
Looking at try jobs for webkit_layout_tests in master 'chromium.webkit' from 8/21/2018 to 8/23/2018, jobs on other builders work normally but not 'WebKit Mac10.13 (retina)'.

For example https://ci.chromium.org/p/chromium/builders/luci.chromium.findit/findit_variable/15520 and https://ci.chromium.org/p/chromium/builders/luci.chromium.findit/findit_variable/15553

Looks like TestOption doesn't work for either build so the required flags are not set.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/229bbf2738eb01c9275360e1a186594dae1f0915

commit 229bbf2738eb01c9275360e1a186594dae1f0915
Author: Chan <chanli@chromium.org>
Date: Sat Aug 25 03:17:38 2018

[Findit] Use canonical_name of a step to look for requested_tests to run in try jobs.

Bug:  876936 , 877682
Change-Id: I48a04b7404f696f5cdbe42ee1766df1a32fadea0
Reviewed-on: https://chromium-review.googlesource.com/1188629
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/229bbf2738eb01c9275360e1a186594dae1f0915/scripts/slave/recipe_modules/findit/api.py

Comment 2 by chanli@chromium.org, Aug 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment