New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876934 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Implement text entry to ScenicWindow from IME

Project Member Reported by w...@chromium.org, Aug 22

Issue description

Hook up composition events and IME show/hide controls in ScenicWindow.
 
Owner: kmarshall@chromium.org
Status: Started (was: Untriaged)
Labels: -Pri-3 M-71 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbfda411da390ce3923a6ea935c3fa056143d3c9

commit dbfda411da390ce3923a6ea935c3fa056143d3c9
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Sep 19 01:11:51 2018

[fuchsia] Add support for on-screen keyboard input.

This patch allows the user to input text in Frames using Fuchsia
IME's on-screen keyboard.

All input event conversion logic is moved to a helper library
"InputEventDispatcher", which takes events from the hardware keyboard
and on-screen keyboard event handlers.

Add platform-specific IME hide/show hooks to RenderWidgetHostViewAura.


Bug:  876934 
Change-Id: I51068e59bd08e9bc0d711bf33c2bbb6f4b0e24ef
Reviewed-on: https://chromium-review.googlesource.com/1213876
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592291}
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/base/ime/BUILD.gn
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/base/ime/fuchsia/input_method_keyboard_controller_fuchsia.cc
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/base/ime/fuchsia/input_method_keyboard_controller_fuchsia.h
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/base/ime/input_method_factory.cc
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/base/ime/input_method_fuchsia.cc
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/base/ime/input_method_fuchsia.h
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/events/BUILD.gn
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/events/fuchsia/input_event_dispatcher.cc
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/events/fuchsia/input_event_dispatcher.h
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/events/fuchsia/input_event_dispatcher_delegate.h
[add] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/events/fuchsia/input_event_dispatcher_unittest.cc
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/ozone/platform/scenic/DEPS
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/dbfda411da390ce3923a6ea935c3fa056143d3c9/webrunner/app/sandbox_policy

Status: Fixed (was: Started)

Sign in to add a comment