New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876931 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
msramek@chromium.org
█ chongz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocked on:
issue 721398


Sign in to add a comment

Followup works for migrating Clear-Site-Data to Network Service

Project Member Reported by chongz@chromium.org, Aug 22 
 issue 721398  migrated Clear-Site-Data to Network Service with the majority of functionalities working (Canary blocking functions). This issue tracks remaining TODOs:

1. Console logs should be deferred for navigations, otherwise developers won't be able to see them.
  * https://chromium-review.googlesource.com/c/chromium/src/+/1170200/10/content/browser/browsing_data/clear_site_data_handler.cc#240

2. In "clear_site_data_handler.cc", |SiteDataClearer| could be merged into |ClearSiteDataHandler| to keep things cleaner.
  * https://chromium-review.googlesource.com/c/chromium/src/+/1170200/10/content/browser/browsing_data/clear_site_data_handler.cc#63

3. Removed "clear_site_data_throttle.cc/.h" and related tests after Network Service was enabled by default, or after |NetworkServiceNetworkDelegate| worked without Network Service.

Comment 1 by chongz@chromium.org, Aug 23

Blockedon: 721398
More notes to 1: DevTools has a "Preserve log" feature for reload / navigations, thus this becomes more of a product excellent issue. A possible approach is to make |ConsoleMessagesDelegate| an |WebContentsObserver|, and listen to |WebContentsObserver::DidFinishNavigation()|.

Comment 2 by dxie@chromium.org, Aug 24

Labels: Hotlist-KnownIssue

Comment 3 by chongz@chromium.org, Aug 24 

Some additional followup works:

4. We might want to move the header parsing work from |ClearSiteDataHandler| to Network Service. However the current difficulty is that we don't have an easy way to output console messages from Network Service.
  * https://chromium-review.googlesource.com/c/chromium/src/+/1170200#message-fe8db3c4942bf003d15d864a41ad526a0d2077cb

5. Current flow is Network Service -> Browser -> Network Service. We may or may not want to reduce the hop / generalize the interface by adding more cookie/cache clearing logic to Network Service.
  * https://chromium-review.googlesource.com/c/chromium/src/+/1170200#message-08f1868f85a1e7f0bb6275611ae931d46d696aba

Comment 4 by chongz@chromium.org, Oct 10

Cc: chongz@chromium.org
Owner: ----
Status: Available (was: Assigned)
Mark as available so others could pickup.
►

Sign in to add a comment