New issue
Advanced search Search tips

Issue 876930 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extensions Click-to-Script: Show the current page access (if any) in the tooltip

Project Member Reported by rdevlin....@chromium.org, Aug 22

Issue description

Per the mocks, the user should be able to see if the extension is either currently allowed to access the page or is requesting access to the page in the tooltip for the extension icon.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55408a2caac4dccf0a5960a4a0061a6e6ed14024

commit 55408a2caac4dccf0a5960a4a0061a6e6ed14024
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Aug 24 00:40:50 2018

[Extensions Click-to-Script] Add a tooltip for page access

Add a line to the tooltip of the extension action indicating if the
extension either wants access to the current page or has access to the
current page (don't indicate if it neither has nor wants access).

Add tests for the same.

Bug:  876930 

Change-Id: Id3da1e77df0f1f1a3109d06be8da1dfa23f543fb
Reviewed-on: https://chromium-review.googlesource.com/1185401
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585674}
[modify] https://crrev.com/55408a2caac4dccf0a5960a4a0061a6e6ed14024/chrome/app/generated_resources.grd
[modify] https://crrev.com/55408a2caac4dccf0a5960a4a0061a6e6ed14024/chrome/browser/ui/extensions/extension_action_view_controller.cc
[modify] https://crrev.com/55408a2caac4dccf0a5960a4a0061a6e6ed14024/chrome/browser/ui/extensions/extension_action_view_controller.h
[modify] https://crrev.com/55408a2caac4dccf0a5960a4a0061a6e6ed14024/chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment