New issue
Advanced search Search tips

Issue 876895 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

Convert LoadRiskData(~) to use BindOnce instead of BindRepeating

Project Member Reported by jsaul@google.com, Aug 22

Issue description

From sujiezhu:

The current usage of loadRiskData() uses Bind() function which is not suggested to be used for now. https://cs.chromium.org/chromium/src/components/autofill/core/browser/credit_card_save_manager.cc?l=248-250&rcl=44e018e9a7c16a3d67ea9424b5afedf51a4559a9
https://cs.chromium.org/chromium/src/components/autofill/core/browser/payments/full_card_request.cc?l=80-82&rcl=3c5b78cc73874a7db642351587fd8058b6d2bff4
I think it's listed as BindRepeating because it's required to be either BindOnce or BindRepeating, and its parent method is overridden by ~4 different callers:
https://cs.chromium.org/chromium/src/components/autofill/core/browser/risk_data_loader.h?l=17-18&rcl=44e018e9a7c16a3d67ea9424b5afedf51a4559a9
We need to investigate why LoadRiskData needs BindRepeating and clean it up if we can change to BindOnce.
 
Cc: -jsaul@google.com
Owner: jsaul@google.com
Status: Fixed (was: Available)
Closing as already Fixed; this was handled by jsaul@ in https://chromium-review.googlesource.com/c/chromium/src/+/1237615 on September 25th.

Sign in to add a comment