New issue
Advanced search Search tips

Issue 876894 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

webrunner_browsertests failing on chromium.linux/Fuchsia x64

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 22

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of skym@chromium.org

webrunner_browsertests failing on chromium.linux/Fuchsia x64

Builders failed on: 
- Fuchsia x64: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64


 
Owner: kmarshall@chromium.org
ContextImplTest.FrameDeletedBeforeContext seems to be flaky, looks like this test case is relatively new, kmarshall@ can you take a look?

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webrunner_browsertests&tests=ContextImplTest.FrameDeletedBeforeContext
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f44eb902f28a65761222db0eeb9d7ff6ab2009

commit 29f44eb902f28a65761222db0eeb9d7ff6ab2009
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 23 00:11:18 2018

[fuchsia] Temporarily disable flaky FrameDeletedBeforeContext test.

The test is disabled because it is causing false negatives on the bots.
It will be reenabled once the root cause is diagnosed and addressed.

TBR=skym@chromium.org

Bug:  876894 
Change-Id: I5ab50f94768bdcd27e06d9f435eddadbf1e1ec5f
Reviewed-on: https://chromium-review.googlesource.com/1186029
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585325}
[modify] https://crrev.com/29f44eb902f28a65761222db0eeb9d7ff6ab2009/webrunner/browser/context_impl_browsertest.cc

 Issue 876888  has been merged into this issue.
Labels: -Sheriff-Chromium
Looks like ContextImplTest.Stop is also flaking now, at least since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/16805 on the bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64?limit=200

I'll disable the flaky test for now.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f6ea73cededae100a81f046c4b1f57146547b7

commit 98f6ea73cededae100a81f046c4b1f57146547b7
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Aug 24 00:11:34 2018

[fuchsia] Fix threading for FilteredServiceDirectory connect call.

Previously, ChildProcessLauncherHelper would bind a ServiceDirectory
connection on the launcher thread. The binding would attach to the
asynchronous dispatcher of the launcher task runner's thread,
rather than the client thread. This generated some test flakiness
during test teardown.

This CL moves the ServiceDirectory binding call so that it runs
in the client thread instead.

Bug:  876894 
Change-Id: I53e05d79a24ab8347e3df697f65f84601f618f40
Reviewed-on: https://chromium-review.googlesource.com/1187125
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585667}
[modify] https://crrev.com/98f6ea73cededae100a81f046c4b1f57146547b7/content/common/sandbox_policy_fuchsia.cc
[modify] https://crrev.com/98f6ea73cededae100a81f046c4b1f57146547b7/content/common/sandbox_policy_fuchsia.h

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cfabf4b039daf2ad18fdae2cd8d2531d209439d

commit 1cfabf4b039daf2ad18fdae2cd8d2531d209439d
Author: Scott Little <sclittle@chromium.org>
Date: Fri Aug 24 00:11:39 2018

Disable flaky test ContextImplTest.Stop().

This test is flaking on the Fuchsia bot, e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/16873

TBR=kmarshall@chromium.org

Bug:  876894 
Change-Id: I455c56835af050aa1f9ff6715a6243500cc06e1d
Reviewed-on: https://chromium-review.googlesource.com/1187552
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585668}
[modify] https://crrev.com/1cfabf4b039daf2ad18fdae2cd8d2531d209439d/webrunner/browser/context_impl_browsertest.cc

Components: UI>Browser
Adding component as part of labeling rotation, please update if incorrect :)
Components: -UI>Browser Internals
Whoops I meant Internals
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec61f4d4ae5077ef4c5fd261c6da6b60e190f53f

commit ec61f4d4ae5077ef4c5fd261c6da6b60e190f53f
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Fri Aug 24 17:29:35 2018

[fuchsia] Re-enable formerly flaky ContextImplBrowsertests.

The underlying cause of the flakes should be fixed in
crrev.com/98f6ea73c.

TBR=wez@chromium.org

Bug:  876894 
Change-Id: Ic3549ff80afc6e8041a1195ab71d39b300789e78
Reviewed-on: https://chromium-review.googlesource.com/1187897
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585892}
[modify] https://crrev.com/ec61f4d4ae5077ef4c5fd261c6da6b60e190f53f/webrunner/browser/context_impl_browsertest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Buildbot remains solid green. Marking as verified.

Sign in to add a comment