Issue metadata
Sign in to add a comment
|
[Video Capture Service] Removing virtual device does not update device list in UI |
||||||||||||||||||||||||
Issue descriptionVirtual device is removed by closing the message pipe of a corresponding mojom.VirtualDevice or mojom.Producer from the client side. This should update the list of devices that the service enumerates. However, potentially due to caching at the level of https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_devices_manager.h?q=MediaDevicesManager&dr=CSs&l=46, the change to the device list does not get propagated to the UI/Renderer. A solution probably has to involve an event being sent out from the service to trigger a cache update, similar to when a physical device is plugged in or unplugged.
,
Aug 22
,
Aug 22
,
Aug 22
Raising to P1 because otherwise there is no chance this is going to be looked at before M70 branches.
,
Aug 24
It looks like at least on Linux this does not seem to be an issue. I added a test case, and it passes on my local Linux workstation. https://chromium-review.googlesource.com/c/chromium/src/+/1188966 It might be that the caching for enumerating devices is not active on Linux. Will check on other platforms as well.
,
Aug 24
It looks like, currently, only Windows and Mac fail the test, which is consistent with the device monitoring being enabled by default only on these two platforms, see https://cs.chromium.org/chromium/src/content/public/common/content_features.cc?l=231&gsn=kMediaDevicesSystemMonitorCache. That is assuming there are no Finch experiments where the monitoring is rolled out on other platforms. We still need to solve this eventually, but for M69/M70 on ChromeOS we might be okay for now.
,
Aug 28
,
Aug 30
Should we bump this to M71?
,
Aug 30
Yes. Didn't make the cut.
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2595a6552a06c96a7c0815a8f78c783bc343e1b commit f2595a6552a06c96a7c0815a8f78c783bc343e1b Author: Christian Fremerey <chfremer@chromium.org> Date: Wed Sep 12 19:42:18 2018 [Video capture service] Add test for adding/removing virtual devices Bug: 876892 Change-Id: I871b13d186df8c49e3522f134f72ef1ca02aabff Reviewed-on: https://chromium-review.googlesource.com/1188966 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590791} [add] https://crrev.com/f2595a6552a06c96a7c0815a8f78c783bc343e1b/content/browser/webrtc/webrtc_video_capture_service_enumeration_browsertest.cc [modify] https://crrev.com/f2595a6552a06c96a7c0815a8f78c783bc343e1b/content/test/BUILD.gn [modify] https://crrev.com/f2595a6552a06c96a7c0815a8f78c783bc343e1b/content/test/data/media/video_capture_test.html [add] https://crrev.com/f2595a6552a06c96a7c0815a8f78c783bc343e1b/content/test/data/media/video_capture_test.js
,
Sep 21
This should resolve itself once Bug 885256 is fixed. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by chfremer@chromium.org
, Aug 22