New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876884 link

Starred by 1 user
Status: Fixed
Owner:
█ akaba@chromium.org
Last visit > 30 days ago
Closed: Aug 23
Cc:
█ fsam...@chromium.org
kylec...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Surface should clear it's observed sinks on deletion

Project Member Reported by akaba@chromium.org, Aug 22 
Currently if a surface got garbage collected, it's observed FrameSinkIds will remain in SurfaceManager which is some what a memory leak since the surface doesn't exist anymore.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2998c3d19f6c77a775582ee1d2afaa2a573b547

commit b2998c3d19f6c77a775582ee1d2afaa2a573b547
Author: akaba <akaba@google.com>
Date: Thu Aug 23 23:30:45 2018

Surface should clear it's observed sinks on deletion

This CL will force a surface to clear it's observed sinks when it gets
garbage collected. This should fix the memory leak problem.

Bug:  876884 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I957fa212053649bf095925f9e7a7da7cdc218829
Reviewed-on: https://chromium-review.googlesource.com/1185874
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585654}
[modify] https://crrev.com/b2998c3d19f6c77a775582ee1d2afaa2a573b547/components/viz/service/surfaces/surface.cc

Comment 2 by akaba@chromium.org, Aug 23

Status: Fixed (was: Assigned)
►

Sign in to add a comment