New issue
Advanced search Search tips

Issue 876865 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Function keys cause the wrong action on Apple Magic Keyboards

Project Member Reported by seobrien@chromium.org, Aug 22

Issue description

What steps will reproduce the problem?
(1) Attach apple magic keypad (with or without numpad) via USB or bluetooth
(2) Press F1

What is the expected result?
Screen should dim, as indicated by key logo

What happens instead?
Chrome goes back one page in history


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2cf3593699abc5da67e8075c76c8889f876f476f

commit 2cf3593699abc5da67e8075c76c8889f876f476f
Author: Jean-Gabriel Gill-Couture <jeangab@jeangab.fr.nf>
Date: Fri Sep 21 01:16:08 2018

UPSTREAM: HID: add usb device id for Apple Magic Keyboard

USB device
	Vendor 05ac (Apple)
	Device 0267 (Magic Keyboard)

This keyboard supports both Bluetooth and USB connections, this patch
only covers USB.

Thanks to Maxime Poulin <maxpoulin64@gmail.com>

Signed-off-by: Jean-Gabriel Gill-Couture <jeangab@jeangab.fr.nf>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit b5d9427549be859dd42c5a6c635bc09d1d07b00b)

BUG= chromium:876865 
TEST=manually test keyboard

Change-Id: I3f4e6ec4ab1876ec496ad662fedb0d4bf330dfb1
Reviewed-on: https://chromium-review.googlesource.com/1185850
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>

[modify] https://crrev.com/2cf3593699abc5da67e8075c76c8889f876f476f/drivers/hid/hid-apple.c
[modify] https://crrev.com/2cf3593699abc5da67e8075c76c8889f876f476f/drivers/hid/hid-core.c
[modify] https://crrev.com/2cf3593699abc5da67e8075c76c8889f876f476f/drivers/hid/hid-ids.h

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0c9db1e3e0ad7377d00153c184b5e3c244c1a848

commit 0c9db1e3e0ad7377d00153c184b5e3c244c1a848
Author: Sean O'Brien <seobrien@chromium.org>
Date: Fri Sep 28 02:44:55 2018

BACKPORT: HID: add support for Apple Magic Keyboards

USB device
	Vendor 05ac (Apple)
	Device 026c (Magic Keyboard with Numeric Keypad)

Bluetooth devices
	Vendor 004c (Apple)
	Device 0267 (Magic Keyboard)
	Device 026c (Magic Keyboard with Numeric Keypad)

Support already exists for the Magic Keyboard over USB connection.
Add support for the Magic Keyboard over Bluetooth connection, and for
the Magic Keyboard with Numeric Keypad over Bluetooth and USB
connection.

Signed-off-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit ee345492437043a79db058a3d4f029ebcb52089a)

Registered device in hid-core as having a special driver.

BUG= chromium:876865 
TEST=manually test keyboards on Bluetooth and USB

Change-Id: I1080db0321450520d9cef332aec5b56bcf42e577
Reviewed-on: https://chromium-review.googlesource.com/1239579
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/0c9db1e3e0ad7377d00153c184b5e3c244c1a848/drivers/hid/hid-apple.c
[modify] https://crrev.com/0c9db1e3e0ad7377d00153c184b5e3c244c1a848/drivers/hid/hid-core.c
[modify] https://crrev.com/0c9db1e3e0ad7377d00153c184b5e3c244c1a848/drivers/hid/hid-ids.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 29

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d46ea135f38e043232338af38f73704f6b67b743

commit d46ea135f38e043232338af38f73704f6b67b743
Author: Jean-Gabriel Gill-Couture <jeangab@jeangab.fr.nf>
Date: Sat Sep 29 03:37:12 2018

UPSTREAM: HID: add usb device id for Apple Magic Keyboard

USB device
	Vendor 05ac (Apple)
	Device 0267 (Magic Keyboard)

This keyboard supports both Bluetooth and USB connections, this patch
only covers USB.

Thanks to Maxime Poulin <maxpoulin64@gmail.com>

Signed-off-by: Jean-Gabriel Gill-Couture <jeangab@jeangab.fr.nf>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit b5d9427549be859dd42c5a6c635bc09d1d07b00b)
Signed-off-by: Sean O'Brien <seobrien@google.com>

BUG= chromium:876865 
TEST=manually test keyboard

Change-Id: I4d30f4ebbe2336f479598535a6b6e08063f4e2cf
Reviewed-on: https://chromium-review.googlesource.com/1250148
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/d46ea135f38e043232338af38f73704f6b67b743/drivers/hid/hid-apple.c
[modify] https://crrev.com/d46ea135f38e043232338af38f73704f6b67b743/drivers/hid/hid-core.c
[modify] https://crrev.com/d46ea135f38e043232338af38f73704f6b67b743/drivers/hid/hid-ids.h

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 9

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1dfc8aea93a8d065455d852c72ed1a48b4884df4

commit 1dfc8aea93a8d065455d852c72ed1a48b4884df4
Author: Sean O'Brien <seobrien@chromium.org>
Date: Tue Oct 09 23:26:40 2018

BACKPORT: HID: add support for Apple Magic Keyboards

USB device
	Vendor 05ac (Apple)
	Device 026c (Magic Keyboard with Numeric Keypad)

Bluetooth devices
	Vendor 004c (Apple)
	Device 0267 (Magic Keyboard)
	Device 026c (Magic Keyboard with Numeric Keypad)

Support already exists for the Magic Keyboard over USB connection.
Add support for the Magic Keyboard over Bluetooth connection, and for
the Magic Keyboard with Numeric Keypad over Bluetooth and USB
connection.

Signed-off-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit ee345492437043a79db058a3d4f029ebcb52089a)

Registered device in hid-core as having a special driver.

BUG= chromium:876865 
TEST=manually test keyboards on Bluetooth and USB

Change-Id: I90aeb40ec01c40dade9cc4d4092fbeda8407d102
Reviewed-on: https://chromium-review.googlesource.com/1252552
Commit-Ready: Sean O'Brien <seobrien@chromium.org>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Sean O'Brien <seobrien@chromium.org>

[modify] https://crrev.com/1dfc8aea93a8d065455d852c72ed1a48b4884df4/drivers/hid/hid-apple.c
[modify] https://crrev.com/1dfc8aea93a8d065455d852c72ed1a48b4884df4/drivers/hid/hid-core.c
[modify] https://crrev.com/1dfc8aea93a8d065455d852c72ed1a48b4884df4/drivers/hid/hid-ids.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b713a219dd403949102d12a42dc7ca7961030586

commit b713a219dd403949102d12a42dc7ca7961030586
Author: Sean O'Brien <seobrien@chromium.org>
Date: Wed Oct 10 12:19:37 2018

BACKPORT: HID: add support for Apple Magic Keyboards

USB device
	Vendor 05ac (Apple)
	Device 026c (Magic Keyboard with Numeric Keypad)

Bluetooth devices
	Vendor 004c (Apple)
	Device 0267 (Magic Keyboard)
	Device 026c (Magic Keyboard with Numeric Keypad)

Support already exists for the Magic Keyboard over USB connection.
Add support for the Magic Keyboard over Bluetooth connection, and for
the Magic Keyboard with Numeric Keypad over Bluetooth and USB
connection.

Signed-off-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit ee345492437043a79db058a3d4f029ebcb52089a)

Registered device in hid-core as having a special driver.

BUG= chromium:876865 
TEST=manually test keyboards on Bluetooth and USB

Change-Id: Ic322ed2e89455f80e9981be9c6e091b9d3fcda13
Reviewed-on: https://chromium-review.googlesource.com/1257422
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sean O'Brien <seobrien@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/b713a219dd403949102d12a42dc7ca7961030586/drivers/hid/hid-apple.c
[modify] https://crrev.com/b713a219dd403949102d12a42dc7ca7961030586/drivers/hid/hid-core.c
[modify] https://crrev.com/b713a219dd403949102d12a42dc7ca7961030586/drivers/hid/hid-ids.h

Status: Fixed (was: Untriaged)

Sign in to add a comment