Typo: 'safe_browsing_g4_update' network annotation |
||
Issue description
It looks like there is a typo in the 'safe_browsing_g4_update' network annotation [1]. Should it not be 'safe_browsing_v4_update'? ('g4' => 'v4')
vakh@, rhalavati@, is this actually a typo? We could rename the annotation to 'v4' instead of 'g4'.
This likely typo broke the network annotation buildbot recently [2]. It has since been brought back to a working state [3], by reverting to the old name (with 'g4'). We are also working to fix the underlying issue in our CQ check in [2].
[1] https://cs.chromium.org/chromium/src/components/safe_browsing/db/v4_update_protocol_manager.cc?l=315&rcl=57d2a1b60549dbbc1db828b51e49254149d9ec6e
[2] https://crbug.com/876855
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1184110
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d313fa208cb688684c076c42bae24b2982c640a commit 1d313fa208cb688684c076c42bae24b2982c640a Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Mon Aug 27 19:12:11 2018 Fix typo in Safe Browsing network annotations 'safe_browsing_g4_update': s/g4/v4/ Bug: 876856 Change-Id: Iefda4121e331a5005d9372e5bfcc493646e5e47d Reviewed-on: https://chromium-review.googlesource.com/1187322 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#586363} [modify] https://crrev.com/1d313fa208cb688684c076c42bae24b2982c640a/components/safe_browsing/db/v4_update_protocol_manager.cc [modify] https://crrev.com/1d313fa208cb688684c076c42bae24b2982c640a/tools/traffic_annotation/summary/annotations.xml
,
Aug 31
|
||
►
Sign in to add a comment |
||
Comment 1 by vakh@chromium.org
, Aug 24Status: Assigned (was: Untriaged)