New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876841 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 847985



Sign in to add a comment

device_unittests failing on chromium.chromiumos/linux-chromeos-rel

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 22

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of skym@chromium.org

device_unittests failing on chromium.chromiumos/linux-chromeos-rel

Builders failed on: 
- linux-chromeos-rel: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel


 
Cc: hongjunchoi@chromium.org
Labels: OS-Chrome
First failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/12315

target device_unittests, test cases

FidoMakeCredentialHandlerTest.TestRequestWithOperationDeniedErrorPlatform
FidoGetAssertionHandlerTest.TestRequestWithOperationDeniedErrorPlatform

Suspected CL of https://chromium-review.googlesource.com/c/chromium/src/+/1182946, reverting.

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305

commit a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305
Author: Sky Malice <skym@chromium.org>
Date: Wed Aug 22 19:48:06 2018

Revert "Move call to GetInfo command after AuthenticatorAdded()"

This reverts commit 42e740f0a8c1ea3fd7f90435983dfe9d772775ab.

Reason for revert: linux-chromeos-rel is failing device_unittests,
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/12315, speculativly reverting this CL.

BUG:  876841 

Original change's description:
> Move call to GetInfo command after AuthenticatorAdded()
> 
> In order to prevent system UI dialogs for BLE/Touch ID from appearing
> prior to WebAuthN UI, we hold off on dispatching request to
> authenticators until user consents on using the specified transport
> type. However, in current implementation, we send GetInfo command to
> external BLE authenticators as soon as we discover the device. This
> would trigger OS UI dialog on Mac for unpaired devices and potentially
> cause BLE connection failures on other platforms. As so, move call to
> GetInfo command after FidoRequestHandlerBase::AuthenticatorAdded().
> 
> Bug:  847985 
> Change-Id: I37b7cd8118c3edb799fa29c36700febbb2b3d08e
> Reviewed-on: https://chromium-review.googlesource.com/1182946
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585130}

TBR=martinkr@google.com,jdoerrie@chromium.org,hongjunchoi@chromium.org

Change-Id: I6ba8d08a85a3e9319257d11e0b2b5e5e01cfc7b3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  847985 
Reviewed-on: https://chromium-review.googlesource.com/1185683
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585210}
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fake_fido_discovery_unittest.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_authenticator.h
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_device.h
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_device_authenticator.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_device_authenticator.h
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_discovery.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_discovery_unittest.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_request_handler_base.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_request_handler_base.h
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/fido_request_handler_unittest.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/get_assertion_handler_unittest.cc
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/mac/authenticator.h
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/mac/authenticator.mm
[modify] https://crrev.com/a02fc8b85fb0acc2856cf3ba332ca1c4dc6bc305/device/fido/make_credential_handler_unittest.cc

Components: Blink>WebAuthentication UI>Browser
Labels: Type-Bug
 Issue 876887  has been merged into this issue.
 Issue 876886  has been merged into this issue.
Labels: -Sheriff-Chromium
Removing Sheriff-Chromium label because it looks the owner is assigned.
Status: Fixed (was: Assigned)

Sign in to add a comment