Make V8 compilation cache work with network service |
|||||
Issue descriptionRenderMessageFilter::DidGenerateCacheableMetadata gets IPCs from the renderer to add compiled JS to the disk cache. There are two modes in that method, the first is what's currently used in the field. It access the disk cache C++ class directly, which won't work with network service. So this needs to remove to the network process. The second mode, as Pavel explained to me, is more secure but it's not turned on by default. I believe that one works already, since it doesn't go through network loading code (URLLoader) to get the result but instead uses custom mojo messages.
,
Aug 22
,
Aug 22
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38 commit 4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38 Author: Clark DuVall <cduvall@chromium.org> Date: Thu Aug 23 22:41:04 2018 Make V8 compilation cache work with network service This adds a new method to NetworkContext to write the cached data. Verified this worked by adding logging in URLLoaderClientImpl::OnReceiveCachedMetadata to make sure we were getting metadata. Previously, this would always have 0 size with network service enabled. Bug: 876836 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I359e8cf594ff8e4435872c7dae018b1ff9d3c044 Reviewed-on: https://chromium-review.googlesource.com/1185907 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#585640} [modify] https://crrev.com/4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38/content/browser/renderer_host/render_message_filter.cc [modify] https://crrev.com/4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38/content/browser/renderer_host/render_message_filter.h [modify] https://crrev.com/4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38/services/network/network_context.cc [modify] https://crrev.com/4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38/services/network/network_context.h [modify] https://crrev.com/4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/4ae630526453e1e71a3cbfd4d1adcf71b8e4fd38/services/network/test/test_network_context.h
,
Aug 23
Thanks!
,
Aug 27
Issue 841039 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rmcilroy@chromium.org
, Aug 22