New issue
Advanced search Search tips

Issue 876825 link

Starred by 2 users
Status: Fixed
Owner:
penghuang@chromium.org
Closed: Sep 10
Cc:
rjkroege@chromium.org
vmi...@chromium.org
piman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove vulkan image view, render pass, etc from chrome

Project Member Reported by penghuang@chromium.org, Aug 22 
//gpu/vulkan has many rendering related code (VulkanCommandBuffer, VulkanCommandPool, VulkanImageView, VulkanRenderPass, etc). But there are not used by Chrome, and in future world, we will use Skia instead of vulkan API to do rendering. So those code is not useful anymore. Probably, we should remove all those code.

Comment 1 by penghuang@chromium.org, Sep 4

Summary: Remove vulkan image view, render pass, etc from chrome (was: Remove vulkan command bufffer, command pool, image view, render pass, etc from chrome)

Comment 2 by piman@chromium.org, Sep 4 

It's not clear we'll use Skia for all rendering code (e.g. implementing some of the RasterDecoderImpl functions for Vulkan, like the Copy ones). That said, if it's in the way, we can always remove it and resurrect later.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3913758d2210fd2c8fefbb2499a87f4ca13e2b09

commit 3913758d2210fd2c8fefbb2499a87f4ca13e2b09
Author: Peng Huang <penghuang@chromium.org>
Date: Mon Sep 10 15:57:59 2018

Remove not used code from //gpu/vulkan

Chrome will use Skia instead of using Vulkan API directly. So some code
will not be used anymore, so remove them.

Bug:  876825 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia572cfa0937a3d09e139f88df22cff85cfb67abb
Reviewed-on: https://chromium-review.googlesource.com/1204921
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589928}
[modify] https://crrev.com/3913758d2210fd2c8fefbb2499a87f4ca13e2b09/gpu/vulkan/BUILD.gn
[modify] https://crrev.com/3913758d2210fd2c8fefbb2499a87f4ca13e2b09/gpu/vulkan/tests/vulkan_test.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_descriptor_layout.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_descriptor_layout.h
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_descriptor_pool.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_descriptor_pool.h
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_descriptor_set.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_descriptor_set.h
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_image_view.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_image_view.h
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_render_pass.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_render_pass.h
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_sampler.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_sampler.h
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_shader_module.cc
[delete] https://crrev.com/06cf8562e71c55494c4a92bc8ded993b9681ed7b/gpu/vulkan/vulkan_shader_module.h
[modify] https://crrev.com/3913758d2210fd2c8fefbb2499a87f4ca13e2b09/gpu/vulkan/vulkan_swap_chain.cc
[modify] https://crrev.com/3913758d2210fd2c8fefbb2499a87f4ca13e2b09/gpu/vulkan/vulkan_swap_chain.h

Comment 4 by penghuang@chromium.org, Sep 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment