Request custom background thumbnails when they come into view |
|||
Issue descriptionSee issue 870401 for context. Copying #3 here to pursue separately: I think that requests for all images in the grid are issued at the same time, so some that won't be visible until the user scrolls are available before the first N that are visible. The tile image sizes are pretty small now ( issue 851990 ), so perhaps it won't make a difference except on very slow networks, but it might be worth requesting the images for tiles that are visible first. Just a hunch - we'd have to try it out to see if it makes any discernible difference.
,
Aug 28
,
Aug 28
May I ask what will be the expected behavior? I can think of two possible scenarios: (1) Lazy loading: The browser will not try to get the image will unless it has appeared in the viewpoint a moment. eg. The image shows up within the view point obviously. Or at least we scroll through it. In this case, the user will not get all the image even though they are on the fast network. (2) Prioritizing a set of image: The browser always load the first N images, N depends on the current window size. And the rest of the image will be loaded after the first N complete. In this case, the user will not get the image in the second or third page until the first page finished loading. wdyt?
,
Aug 28
Yeah, I think both of these were approaches we discussed, with the disadvantage of any staged loading being that users on fast networks don't need to wait to load these images. As a first step, how about loading the first page of images (currently 9), and then requesting the rest?
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc450f7f0e69e8285d1296976f47d36c0c6216eb commit bc450f7f0e69e8285d1296976f47d36c0c6216eb Author: Weilun Shi <sweilun@chromium.org> Date: Thu Sep 13 23:15:19 2018 [NTP] Load the first 9 tiles for better experience on slow network Now, the browser will not load the rest of the tile images until the first N tile images finished loading. Now the N set to 9 which is the default number of tiles will show in the custom background dialog. Screencast on fast network: https://screencast.googleplex.com/cast/NDc0OTAyNTE5MDM0Njc1Mnw1OTJjZmIyNy1kOA Screencast on slow network: https://screencast.googleplex.com/cast/NjY0MDQ4NzU4MjY2MjY1Nnw3ZmZkNGY5Ni00Zg Bug: 876814 Change-Id: Id7f9e3e9538399f7fb64a68b7723ca39d6f19d65 Reviewed-on: https://chromium-review.googlesource.com/1220183 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#591200} [modify] https://crrev.com/bc450f7f0e69e8285d1296976f47d36c0c6216eb/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Sep 13
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4286e847423c2ab642b80eef7135a7e60aa021a commit a4286e847423c2ab642b80eef7135a7e60aa021a Author: Weilun Shi <sweilun@chromium.org> Date: Thu Sep 20 01:27:42 2018 [NTP] Dynamically determine N based on the current window size Dynamically determine the first n tiles get loaded based on the window size. Bug: 876814 Change-Id: I7830faff7d090c8b33c7726ca3faa3439fe52dda Reviewed-on: https://chromium-review.googlesource.com/1232686 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592650} [modify] https://crrev.com/a4286e847423c2ab642b80eef7135a7e60aa021a/chrome/browser/resources/local_ntp/custom_backgrounds.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by twelling...@chromium.org
, Aug 28