New issue
Advanced search Search tips

Issue 876806 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Touch ID authenticator prompt appears before UI sheet

Project Member Reported by martinkr@google.com, Aug 22

Issue description

The native Touch ID prompt currently appears before the corresponding Chrome UI sheet. This is because we request the UI sheet do be changed and then immediately dispatch the request rather than waiting for the UI sheet to get painted, animated and whatever else happens invisibly in the background.

crrev.com/c/1185237 addresses this by adding a fixed delay to the request dispatch. We want to have small delay anyway in between the Chrome and native UI appearing so that the two don't render at the same instance, which might be confusing. However, I fear that this fixed delay might not be good enough because the time it takes for the Chrome UI sheet to render might be too dependent on hardware, system load etc. Therefore it would be better to start counting the delay **after** the UI sheet has fully animated, but I currently have no idea if there is a corresponding observer/event that we can watch for to achieve this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e03ef80704ff372bde51966b9ea54074754c8e34

commit e03ef80704ff372bde51966b9ea54074754c8e34
Author: Martin Kreichgauer <martinkr@google.com>
Date: Thu Aug 23 09:40:05 2018

fido: add a delay for dispatching requests to Touch ID from the UI

Bug:  678128 , 847985 , 876806 
Change-Id: I27acd32a7796edff6aabce304b698365063a4f7e
Reviewed-on: https://chromium-review.googlesource.com/1185237
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585439}
[modify] https://crrev.com/e03ef80704ff372bde51966b9ea54074754c8e34/chrome/browser/webauthn/authenticator_request_dialog_model.cc

Martin, is this fixed?
Status: Fixed (was: Assigned)
Yeah, I think we can close this.

The underlying issue is that we can't determine when the Chrome UI has finished rendering before we dispatch to the Touch ID authenticator. But this doesn't matter in practice, because we now have a deliberate .7sec delay anyway.

Sign in to add a comment