New issue
Advanced search Search tips

Issue 876805 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 914423



Sign in to add a comment

Add BrowserSwitcher policies

Project Member Reported by nicolaso@chromium.org, Aug 22

Issue description

At least, we'll need:

1. The policies from the LBS extension [1].
2. An ExtensionPolicyMigrator [2] to use the LBS extension's policies as a fallback, if the Chrome policies aren't set.

(2) makes sure existing setups don't break when we release BrowserSwitcher officially.

We should probably defer step (2) until Chrome fully supports all the features from the original extension.

[1] https://github.com/LegacyBrowserSupport/legacy-browser-support/blob/master/chrome_extension/schema.json
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1158968
 
Components: Enterprise>BrowserSwitcher
Labels: -BrowserSwitcher
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f0098ae233017efe7348fbf992172bcb324cb4b

commit 6f0098ae233017efe7348fbf992172bcb324cb4b
Author: Nicolas Ouellet-payeur <nicolaso@chromium.org>
Date: Wed Oct 31 18:20:12 2018

[BrowserSwitcher] Add policies and map to existing prefs

BrowserSwitcher is no longer controllable by the prefs themselves. They
have to be set through the policies to be effective.

Bug:  876805 
Change-Id: I9f819de1d4b30df5ca299653a24fa392060ed820
Reviewed-on: https://chromium-review.googlesource.com/c/1293560
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604335}
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/alternative_browser_launcher.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/alternative_browser_launcher_unittest.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/browser_switcher_prefs.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/browser_switcher_prefs.h
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/browser_switcher_service.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/browser_switcher_service.h
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/browser_switcher_service_browsertest.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/browser_switcher_sitelist.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/browser_switcher/browser_switcher_sitelist_unittest.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/components/policy/resources/policy_templates.json
[modify] https://crrev.com/6f0098ae233017efe7348fbf992172bcb324cb4b/tools/metrics/histograms/enums.xml

Status: Verified (was: Untriaged)

Sign in to add a comment