New issue
Advanced search Search tips

Issue 876804 link

Starred by 1 user
Status: Verified
Owner:
nicolaso@chromium.org
Closed: Sep 6
Cc:
pastarmovj@chromium.org
georgesak@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 914423



Sign in to add a comment

Create AlternativeBrowserLauncher

Project Member Reported by nicolaso@chromium.org, Aug 22 
A class that handles the actual launching of the alternate browser. It should read prefs & such to know which browser to open and  decide which flags to use.

Eventually, this class will also handle opening the action.html page.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/978740fb6fe6c3917638a052417d8e1f77b97fb2

commit 978740fb6fe6c3917638a052417d8e1f77b97fb2
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Thu Sep 06 20:17:19 2018

[BrowserSwitcher] Add AlternativeBrowserLauncher

|AlternativeBrowserLauncher| uses prefs to decide which browser to
launch, and then uses an |AlternativeBrowserDriver| to do I/O operations
that launch the browser.

Bug:  876804 
Change-Id: I8461d72e8fb711a50148c3d7f27a2b286493df9f
Reviewed-on: https://chromium-review.googlesource.com/1197185
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589267}
[modify] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/BUILD.gn
[add] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/browser_switcher/alternative_browser_driver.cc
[add] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/browser_switcher/alternative_browser_driver.h
[add] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/browser_switcher/alternative_browser_launcher.cc
[add] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/browser_switcher/alternative_browser_launcher.h
[add] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/browser_switcher/alternative_browser_launcher_unittest.cc
[modify] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/browser_switcher/browser_switcher_prefs.cc
[modify] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/browser/browser_switcher/browser_switcher_prefs.h
[modify] https://crrev.com/978740fb6fe6c3917638a052417d8e1f77b97fb2/chrome/test/BUILD.gn

Comment 2 by nicolaso@chromium.org, Sep 6

Status: Verified (was: Untriaged)
►

Sign in to add a comment