New issue
Advanced search Search tips

Issue 876802 link

Starred by 1 user
Status: Verified
Owner:
nicolaso@chromium.org
Closed: Sep 13
Cc:
pastarmovj@chromium.org
georgesak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 914423



Sign in to add a comment

Create BrowserSwitcherTabHelper

Project Member Reported by nicolaso@chromium.org, Aug 22 
After  https://crbug.com/874971  lands, we should create a BrowserSwitcherTabHelper for every tab, that listens to navigations.

When a navigation occurs, it should check query the BrowserSwitcherSitelist, to know whether it should open in IE. If that's the case, it should call an AlternativeBrowserLauncher to launch IE.

Comment 1 by nicolaso@chromium.org, Sep 11

Components: Enterprise>BrowserSwitcher
Labels: -BrowserSwitcher
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/995e77706df44b70134f735f44b9b196e5c5b413

commit 995e77706df44b70134f735f44b9b196e5c5b413
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Thu Sep 13 16:02:13 2018

[BrowserSwitcher] Add BrowserSwitcherNavigationThrottle

This lets us listen to navigations/redirects and launch an alternative
browser if the URL is whitelisted for BrowserSwitcher.

Bug:  876802 ,  876752 
Change-Id: I1c2a87ed3e918d0c5443d58d113e5edec431e627
Reviewed-on: https://chromium-review.googlesource.com/1211746
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591029}
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/BUILD.gn
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/alternative_browser_driver.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/alternative_browser_launcher.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/alternative_browser_launcher.h
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/alternative_browser_launcher_unittest.cc
[add] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_navigation_throttle.cc
[add] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_navigation_throttle.h
[add] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_navigation_throttle_unittest.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_service.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_service.h
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_sitelist.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_sitelist.h
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/browser_switcher/browser_switcher_sitelist_unittest.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/prerender/prerender_final_status.cc
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/browser/prerender/prerender_final_status.h
[modify] https://crrev.com/995e77706df44b70134f735f44b9b196e5c5b413/chrome/test/BUILD.gn

Comment 3 by nicolaso@chromium.org, Sep 13

Status: Verified (was: Untriaged)
►

Sign in to add a comment