There are a few places where the model needs to be tweaked.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9a1dfcdd7d5cda9c13d182fc410105213fd29a67 commit 9a1dfcdd7d5cda9c13d182fc410105213fd29a67 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Aug 30 23:13:45 2018 [FindIt] Remove unused id for FlakeIssue The id for FlakeIssue model is never used, thus remove it. Bug: 876797 Change-Id: Ibc4cc06edbcfd36475fe29e1cb682c803ef920cb Reviewed-on: https://chromium-review.googlesource.com/1195948 Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#17339} [modify] https://crrev.com/9a1dfcdd7d5cda9c13d182fc410105213fd29a67/appengine/findit/model/flake/detection/test/flake_issue_test.py [modify] https://crrev.com/9a1dfcdd7d5cda9c13d182fc410105213fd29a67/appengine/findit/model/flake/detection/flake_issue.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703 commit 5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703 Author: Yuke Liao <liaoyuke@chromium.org> Date: Fri Aug 31 21:37:47 2018 [Findit] Move Flake and FlakeIssue out of flake/detection This is a pure refactoring CL. Now that Flake Analyzer also uses the Flake and FlakeIssue models, it makes more sense to move these two models out of the flake/detection folder. Bug: 876797 Change-Id: Iee2756d7b5f05ee74fbd50ae761bc04004a9b2b5 Reviewed-on: https://chromium-review.googlesource.com/1199458 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#17355} [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/handlers/flake/detection/show_flake.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/model/flake/detection/test/flake_occurrence_test.py [rename] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/model/flake/test/flake_issue_test.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/flake_failure/flake_report_util.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/flake_detection/flake_report_util.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/flake_detection/test/detect_cq_false_rejection_flakes_test.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/test/issue_tracking_service_test.py [rename] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/model/flake/test/flake_test.py [rename] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/model/flake/flake_issue.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/flake_failure/test/flake_report_util_test.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/flake_detection/test/flake_report_util_test.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/model/flake/detection/flake_occurrence.py [rename] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/model/flake/flake.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/handlers/flake/detection/test/show_flake_test.py [modify] https://crrev.com/5b16c9465ccb53c5b3dbfcf0dd49f073d3bb6703/appengine/findit/services/issue_tracking_service.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a71e7c744f91b3be8d76730bdcb72cd3483ef044 commit a71e7c744f91b3be8d76730bdcb72cd3483ef044 Author: Yuke Liao <liaoyuke@chromium.org> Date: Tue Sep 11 17:54:32 2018 [Findit] Remove unused fields in data model The reference_succeeded_build_id is not used, so remove it. Bug: 876797 Change-Id: I18243ed1832aa7f2d79c008bb9dd5bacf8e301c8 Reviewed-on: https://chromium-review.googlesource.com/1220089 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#17504} [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/model/flake/detection/test/flake_occurrence_test.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/services/test/apis_test.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/services/flake_detection/flaky_tests.cq_false_rejection.sql [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/services/flake_detection/test/detect_cq_false_rejection_flakes_test.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/handlers/flake/detection/flake_detection_utils.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/services/flake_detection/test/flake_report_util_test.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/model/flake/detection/flake_occurrence.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/handlers/flake/detection/test/show_flake_test.py [modify] https://crrev.com/a71e7c744f91b3be8d76730bdcb72cd3483ef044/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/54014673d57246054b16763546708dd2a109bb3a commit 54014673d57246054b16763546708dd2a109bb3a Author: Yuke Liao <liaoyuke@chromium.org> Date: Tue Sep 11 18:14:27 2018 [Findit] Rename a field in FlakeIssue model This CL renames a field in the FlakeIssue data model. Bug: 876797 Change-Id: If5e52d9f41c6644a5b5792c471f8dfe2ef3a5f4e Reviewed-on: https://chromium-review.googlesource.com/1220189 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#17505} [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/model/flake/test/flake_issue_test.py [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/ui/elements/flake_detection/flake-demo.html [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/model/flake/flake_issue.py [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/services/flake_failure/test/flake_report_util_test.py [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/services/flake_detection/test/flake_report_util_test.py [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/services/flake_detection/flake_report_util.py [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/handlers/flake/detection/test/show_flake_test.py [modify] https://crrev.com/54014673d57246054b16763546708dd2a109bb3a/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/c756bb65c5fd57abbf85e87412e9574e5f032d03 commit c756bb65c5fd57abbf85e87412e9574e5f032d03 Author: Yuke Liao <liaoyuke@chromium.org> Date: Tue Sep 11 19:54:36 2018 [Findit] Rename a field in FlakeOccurence model This CL renames step_name to step_ui_name in FlakeOccurrence model to make it more clear that this field refers to the exactly name of the step that is displayed on the build page UI. Bug: 876797 Change-Id: I7ac58c1cba6b1f71e6d1300ac7d32c380c2f95a2 Reviewed-on: https://chromium-review.googlesource.com/1220098 Reviewed-by: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#17508} [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/model/flake/detection/test/flake_occurrence_test.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/services/flake_detection/flaky_tests.cq_false_rejection.sql [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/services/flake_detection/test/detect_cq_false_rejection_flakes_test.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/ui/elements/flake_detection/flake-occurrence.html [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/services/test/apis_test.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/services/flake_detection/test/flake_report_util_test.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/services/apis.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/model/flake/detection/flake_occurrence.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/handlers/flake/detection/test/show_flake_test.py [modify] https://crrev.com/c756bb65c5fd57abbf85e87412e9574e5f032d03/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py
Comment 1 by bugdroid1@chromium.org
, Aug 30