New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876796 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Add accessibility labels to setup flow & settings

Project Member Reported by khorimoto@chromium.org, Aug 22

Issue description

Owner: jordynass@chromium.org
Labels: -Restrict-View-Google Merge-Request-70
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d691a6be31a86d19b775093ba9b1be16955a8c8

commit 7d691a6be31a86d19b775093ba9b1be16955a8c8
Author: Yuki Shiino <yukishiino@chromium.org>
Date: Fri Sep 07 09:15:08 2018

Revert "[CrOS MultiDevice] Settings UI A11y labels."

This reverts commit a11e3884626644c13ea216d7c04c18ede29071a0.

Reason for revert: Suspicious to have broken viz_browser_tests and webui_polymer2_browser_tests.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7689
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936081737798843840/+/steps/viz_browser_tests/0/logs/CrSettingsMultideviceFeatureToggleTest.All/0

Original change's description:
> [CrOS MultiDevice] Settings UI A11y labels.
> 
> 
> Bug:  876796 
> Change-Id: Ie369384f218fde83ae03f21add99c0573ab97912
> Reviewed-on: https://chromium-review.googlesource.com/1211915
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589397}

TBR=hcarmona@chromium.org,jlklein@chromium.org,jordynass@chromium.org

Change-Id: Ife1c75063e197a32142604f3f05c964910721079
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  876796 
Reviewed-on: https://chromium-review.googlesource.com/1212212
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589469}
[modify] https://crrev.com/7d691a6be31a86d19b775093ba9b1be16955a8c8/chrome/browser/resources/settings/multidevice_page/multidevice_feature_behavior.js
[modify] https://crrev.com/7d691a6be31a86d19b775093ba9b1be16955a8c8/chrome/browser/resources/settings/multidevice_page/multidevice_feature_item.html
[modify] https://crrev.com/7d691a6be31a86d19b775093ba9b1be16955a8c8/chrome/browser/resources/settings/multidevice_page/multidevice_feature_toggle.html
[modify] https://crrev.com/7d691a6be31a86d19b775093ba9b1be16955a8c8/chrome/browser/resources/settings/multidevice_page/multidevice_page.html
[modify] https://crrev.com/7d691a6be31a86d19b775093ba9b1be16955a8c8/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html

Labels: -Merge-Request-70 Merge-Approved-70
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/320ee4295eb7fabaa112f08d1aacc88efd1444e5

commit 320ee4295eb7fabaa112f08d1aacc88efd1444e5
Author: Jeremy Klein <jlklein@google.com>
Date: Sat Sep 08 01:45:12 2018

Reland "[CrOS MultiDevice] Settings UI A11y labels."

Original change was a11e3884626644c13ea216d7c04c18ede29071a0 (Reviewed
on  https://chromium-review.googlesource.com/1211915).

The original change passed all CQ tests, but was reverted in [1] because
it broke a debug trybot [2]. The fix was just to add an import to
i18n_setup.html in multidevice_feature_behavior.html. Verified all tests
are now passing.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1212212
[2] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936081737798843840/+/steps/viz_browser_tests/0/logs/CrSettingsMultideviceFeatureToggleTest.All/0

Bug:  876796 
Change-Id: Ia78bb41ea459f7c31c60a3b3d0fcc9f32bb5eeb2
Reviewed-on: https://chromium-review.googlesource.com/1214422
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589751}
[modify] https://crrev.com/320ee4295eb7fabaa112f08d1aacc88efd1444e5/chrome/browser/resources/settings/multidevice_page/multidevice_feature_behavior.html
[modify] https://crrev.com/320ee4295eb7fabaa112f08d1aacc88efd1444e5/chrome/browser/resources/settings/multidevice_page/multidevice_feature_behavior.js
[modify] https://crrev.com/320ee4295eb7fabaa112f08d1aacc88efd1444e5/chrome/browser/resources/settings/multidevice_page/multidevice_feature_item.html
[modify] https://crrev.com/320ee4295eb7fabaa112f08d1aacc88efd1444e5/chrome/browser/resources/settings/multidevice_page/multidevice_feature_toggle.html
[modify] https://crrev.com/320ee4295eb7fabaa112f08d1aacc88efd1444e5/chrome/browser/resources/settings/multidevice_page/multidevice_page.html
[modify] https://crrev.com/320ee4295eb7fabaa112f08d1aacc88efd1444e5/chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html

Project Member

Comment 7 by sheriffbot@chromium.org, Sep 11

Cc: geo...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-70 M-71
Status: Started (was: Available)
Labels: -Merge-Approved-70
Status: Fixed (was: Started)
Let's not bother merging this to 70, Jordy. I know you've been dealing with issues on the 70 branch with this CL, so I'd rather just not worry about it for now. Can you file a P2 for the non-blocking a11y issues that Laura brought up?

Sign in to add a comment