New issue
Advanced search Search tips

Issue 876795 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

chromite: Make RunCommand default LC_MESSAGES=C

Project Member Reported by la...@chromium.org, Aug 22 
vapier:

oof, looking at possibly localized error output is dangerous.  you want to set LC_MESSAGES='C' in RunCommand to handle that.

maybe we should be setting LC_MESSAGES='C' all the time in RunCommand ?

Comment 1 by vapier@chromium.org, Aug 22 

this does has some obvious downsides if people have LC_MESSAGES set to their own language, but the counter is:
- all CrOS tooling is written using English only
- people running tools and checking the output often only check for English messages, and setting LC_MESSAGES=C is missed
- Gentoo sets LC_MESSAGES=C in the ebuild env for the same reason

Comment 2 by la...@chromium.org, Sep 4

Labels: -Type-Task Type-Feature
Status: Assigned (was: Untriaged)

Comment 3 by lannm@google.com, Sep 10

Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by bugdroid, Today (4 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6fd3e070ddcf85122eab4efe94fcf1136c590290

commit 6fd3e070ddcf85122eab4efe94fcf1136c590290
Author: Chris McDonald <cjmcdonald@chromium.org>
Date: Wed Jan 23 05:05:24 2019

RunCommand: Set environment variable LC_MESSAGES=C by default

BUG=chromium:876795
TEST=`FEATURES='test' emerge chromite`

Change-Id: Ic441d76a24d55894235332f62623334e6bd34689
Reviewed-on: https://chromium-review.googlesource.com/1413161
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6fd3e070ddcf85122eab4efe94fcf1136c590290/lib/cros_build_lib.py
[modify] https://crrev.com/6fd3e070ddcf85122eab4efe94fcf1136c590290/lib/cros_build_lib_unittest.py
Project Member

Comment 5 by bugdroid, Today (4 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6fd3e070ddcf85122eab4efe94fcf1136c590290

commit 6fd3e070ddcf85122eab4efe94fcf1136c590290
Author: Chris McDonald <cjmcdonald@chromium.org>
Date: Wed Jan 23 05:05:24 2019

RunCommand: Set environment variable LC_MESSAGES=C by default

BUG=chromium:876795
TEST=`FEATURES='test' emerge chromite`

Change-Id: Ic441d76a24d55894235332f62623334e6bd34689
Reviewed-on: https://chromium-review.googlesource.com/1413161
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6fd3e070ddcf85122eab4efe94fcf1136c590290/lib/cros_build_lib.py
[modify] https://crrev.com/6fd3e070ddcf85122eab4efe94fcf1136c590290/lib/cros_build_lib_unittest.py
Project Member

Comment 6 by bugdroid, Today (4 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6fd3e070ddcf85122eab4efe94fcf1136c590290

commit 6fd3e070ddcf85122eab4efe94fcf1136c590290
Author: Chris McDonald <cjmcdonald@chromium.org>
Date: Wed Jan 23 05:05:24 2019

RunCommand: Set environment variable LC_MESSAGES=C by default

BUG=chromium:876795
TEST=`FEATURES='test' emerge chromite`

Change-Id: Ic441d76a24d55894235332f62623334e6bd34689
Reviewed-on: https://chromium-review.googlesource.com/1413161
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Chris McDonald <cjmcdonald@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6fd3e070ddcf85122eab4efe94fcf1136c590290/lib/cros_build_lib.py
[modify] https://crrev.com/6fd3e070ddcf85122eab4efe94fcf1136c590290/lib/cros_build_lib_unittest.py
►

Sign in to add a comment