New issue
Advanced search Search tips

Issue 876787 link

Starred by 1 user
Status: WontFix
Owner:
c...@chromium.org
Closed: Dec 15
Cc:
dmu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 843797


Sign in to add a comment

IndexedDB: Dispatch storage corruption error event

Project Member Reported by c...@chromium.org, Aug 22 
Currently IndexedDB backing stores can become corrupt in a way that the IDB factory open call will return success but that part of the backing store is absent.  One example cause is when a migration occurred from version 2 to 3 and in one branch neglected to update the version marker to 3.  For users in this state, alert applications to the corruption error so they can take action.

Comment 1 by c...@chromium.org, Aug 22

Owner: c...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by c...@chromium.org, Aug 24

Blockedon: 843797
While testing a ToT checkout for corruption handling, I see:
FATAL:appcache_host.cc(133)] Check failed: !first_party_url_.is_empty().

This is tracked in issue 843797.  I let Victor know, who's currently looking into that bug.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff82a4864410bf23eb784a820088e5da2daf93b8

commit ff82a4864410bf23eb784a820088e5da2daf93b8
Author: Chase Phillips <cmp@chromium.org>
Date: Mon Aug 27 21:56:10 2018

IndexedDB: Add "Force schema downgrade" option on chrome://indexeddb-internals/

As part of on-going cleanup to dispatch an event on corruption
detection, add a "Force schema downgrade" option on an internal
page so that web developers can trigger corruption in a way
that will allow them to test and verify their apps correctly
handle the event.

Bug:  876787 
Change-Id: If03d47ce8ec3bc930e9a5a8a7e04835116cf4a36
Reviewed-on: https://chromium-review.googlesource.com/1183586
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586434}
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_context_impl.h
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_factory.h
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_factory_impl.h
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_internals_ui.cc
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_internals_ui.h
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/indexed_db_reporting.h
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/indexed_db/mock_indexed_db_factory.h
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/resources/indexed_db/indexeddb_internals.html
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/content/browser/resources/indexed_db/indexeddb_internals.js
[modify] https://crrev.com/ff82a4864410bf23eb784a820088e5da2daf93b8/tools/metrics/histograms/enums.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad

commit 42a25b1732d6aca5bf1842d0e82eaca2b472b0ad
Author: Chase Phillips <cmp@chromium.org>
Date: Mon Sep 17 22:56:35 2018

IndexedDB: Verify the v2 schema corruption lifecycle

Bug:  876787 
Change-Id: I74e4ab4fa35dfd7bdb3c0b7af0ecafe4e0151e30
Reviewed-on: https://chromium-review.googlesource.com/1226250
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591860}
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_browsertest.cc
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_context_impl.h
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_factory.h
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/indexed_db_factory_impl.h
[modify] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/browser/indexed_db/mock_indexed_db_factory.h
[add] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/test/data/indexeddb/v2schemacorrupt_reopen.html
[add] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/test/data/indexeddb/v2schemacorrupt_setup.html
[add] https://crrev.com/42a25b1732d6aca5bf1842d0e82eaca2b472b0ad/content/test/data/indexeddb/v2schemacorrupt_verify.html

Comment 5 by c...@chromium.org, Dec 15

Cc: dmu...@chromium.org
Status: WontFix (was: Assigned)
We're putting this on the shelf, so marking this WontFix.
►

Sign in to add a comment