Swiping a window down shows the launcher animation under the overview mode screen |
||
Issue descriptionChrome Version: 70.0.3530.0 What steps will reproduce the problem? (1) Open any window (2) Swipe down from the top of the screen What is the expected result? Vanilla overview mode things. What happens instead? The launcher animates from the top of the screen then dissapears. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Aug 22
You might want to turn [1] into a public class function if that helps. [1] https://cs.chromium.org/chromium/src/ash/wm/overview/window_selector_controller.cc?rcl=a33e27aa99eb18313fdbbea8ccf4004753bc746a&l=85
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/840e6acc20b521c933fa34d527c0bdc01f6d9f04 commit 840e6acc20b521c933fa34d527c0bdc01f6d9f04 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Aug 23 17:59:09 2018 Fix app list animation issue for toggling overview mode Background: When active window exists, toggling overview mode will show a enlarge/shrink animation instead of slide up/down animation. In this case, app list should stay invisible during the animation. Changes: Only run animation when overview mode is using slide animation. Otherwise, set the animation duration to 0 so that app list will immediately disappear when overview mode is on and will immediately show up after overview mode animation when overview mode is off. Bug: 876781 Change-Id: Ifc7af8838beead1dbd1b6d70ee46eec3af19dc19 Reviewed-on: https://chromium-review.googlesource.com/1186036 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585540} [modify] https://crrev.com/840e6acc20b521c933fa34d527c0bdc01f6d9f04/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/840e6acc20b521c933fa34d527c0bdc01f6d9f04/ash/app_list/presenter/app_list_presenter_impl.cc [modify] https://crrev.com/840e6acc20b521c933fa34d527c0bdc01f6d9f04/ash/app_list/presenter/app_list_presenter_impl.h
,
Aug 23
|
||
►
Sign in to add a comment |
||
Comment 1 by sammiequon@chromium.org
, Aug 22