Regression in text analysis from SkRemoteGlyphCache |
|||||
Issue descriptionThe latest CT results shows a regression in glyph cache misses for OOP raster for an analysis run on rendering.cluster_telemetry benchmark. Here are the results from the run: https://ct.skia.org/results/cluster-telemetry/tasks/benchmark_runs/khushalsagar-20180821232853/consolidated_outputs/khushalsagar-20180821232853.output This run missed herb's tentative fix: https://skia-review.googlesource.com/c/skia/+/148384, I triggered it before the change was rolled into chromium. I scheduled another run now that that it has rolled in. Filing a bug to make sure these are resolved before M70 hits beta.
,
Aug 27
Issue 877969 has been merged into this issue.
,
Aug 27
The following revision refers to this bug: https://skia.googlesource.com/skia/+/d4255ed037271243050ec2f965ff6a65f99a1b8b commit d4255ed037271243050ec2f965ff6a65f99a1b8b Author: Herb Derby <herb@google.com> Date: Mon Aug 27 22:34:42 2018 Handle the glyph too big path fallback BUG= chromium:876767 Change-Id: I06ea46c14e602b966600abaed3e6c059e40539f8 Reviewed-on: https://skia-review.googlesource.com/149821 Commit-Queue: Khusal Sagar <khushalsagar@chromium.org> Reviewed-by: Khusal Sagar <khushalsagar@chromium.org> [modify] https://crrev.com/d4255ed037271243050ec2f965ff6a65f99a1b8b/src/core/SkRemoteGlyphCache.cpp
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6dbf129ab14284f39a4b10f8f52afe90cbdad27 commit f6dbf129ab14284f39a4b10f8f52afe90cbdad27 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Aug 27 23:56:58 2018 Roll src/third_party/skia da6289c5f352..d4255ed03727 (3 commits) https://skia.googlesource.com/skia.git/+log/da6289c5f352..d4255ed03727 git log da6289c5f352..d4255ed03727 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 herb@google.com Handle the glyph too big path fallback 2018-08-27 egdaniel@google.com Have GrAHardwareBufferImageGenerator use lazy proxies. 2018-08-27 brianosman@google.com Reland "Add support for unpremul image sources in the GPU backend" Created with: gclient setdep -r src/third_party/skia@d4255ed03727 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:876767 TBR=stephana@chromium.org Change-Id: I9be4255fe5ec3e3d9d6507b56bb97e20e2d9cf18 Reviewed-on: https://chromium-review.googlesource.com/1192243 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586504} [modify] https://crrev.com/f6dbf129ab14284f39a4b10f8f52afe90cbdad27/DEPS
,
Aug 28
The following revision refers to this bug: https://skia.googlesource.com/skia/+/d9c93640bbe1ec02df1e57fe444a4225994d1e8d commit d9c93640bbe1ec02df1e57fe444a4225994d1e8d Author: Herb Derby <herb@google.com> Date: Tue Aug 28 19:12:42 2018 Make the two too-large-glyph comparisons be the same BUG= chromium:876767 Change-Id: I18184fe4ab50e08450748cc4cce5ac4560fc2251 Reviewed-on: https://skia-review.googlesource.com/150144 Reviewed-by: Khusal Sagar <khushalsagar@chromium.org> Commit-Queue: Herb Derby <herb@google.com> [modify] https://crrev.com/d9c93640bbe1ec02df1e57fe444a4225994d1e8d/src/core/SkGlyphRun.h
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0db17a0b62ff65bc50c30af0a9f77df9733f4e48 commit 0db17a0b62ff65bc50c30af0a9f77df9733f4e48 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Aug 28 23:00:08 2018 Roll src/third_party/skia 7ba1d64f0706..f2a3d8466ca4 (7 commits) https://skia.googlesource.com/skia.git/+log/7ba1d64f0706..f2a3d8466ca4 git log 7ba1d64f0706..f2a3d8466ca4 --date=short --no-merges --format='%ad %ae %s' 2018-08-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 47f6dd0d4a21..1e1b731a9895 (1 commits) 2018-08-28 caryclark@skia.org bookmaker report only changed files 2018-08-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-28 herb@google.com Make the two too-large-glyph comparisons be the same 2018-08-28 liyuqian@google.com Further improve AA choice 2018-08-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-28 egdaniel@google.com [infra] Update Win Intel drivers. Created with: gclient setdep -r src/third_party/skia@f2a3d8466ca4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:876767 TBR=stephana@chromium.org Change-Id: I29784adc9a6d223e7e3519358f094b497e188984 Reviewed-on: https://chromium-review.googlesource.com/1194691 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586909} [modify] https://crrev.com/0db17a0b62ff65bc50c30af0a9f77df9733f4e48/DEPS
,
Aug 29
The following revision refers to this bug: https://skia.googlesource.com/skia/+/9f85b5116e333a65ecfecb66adfdf7f72bb9e9ef commit 9f85b5116e333a65ecfecb66adfdf7f72bb9e9ef Author: Herb Derby <herb@google.com> Date: Wed Aug 29 18:25:59 2018 Check that mask to path fallback happens BUG= chromium:876767 Change-Id: I6aadf329af836a1e03aa85b34a58830be00ff750 Reviewed-on: https://skia-review.googlesource.com/150135 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Khusal Sagar <khushalsagar@chromium.org> [modify] https://crrev.com/9f85b5116e333a65ecfecb66adfdf7f72bb9e9ef/src/core/SkGlyphRun.cpp [modify] https://crrev.com/9f85b5116e333a65ecfecb66adfdf7f72bb9e9ef/src/core/SkGlyphRun.h [modify] https://crrev.com/9f85b5116e333a65ecfecb66adfdf7f72bb9e9ef/tests/SkRemoteGlyphCacheTest.cpp
,
Aug 29
The following revision refers to this bug: https://skia.googlesource.com/skia/+/eb0bb732f43fdf7f8cf74a68579ee11da1c987f5 commit eb0bb732f43fdf7f8cf74a68579ee11da1c987f5 Author: Herb Derby <herb@google.com> Date: Wed Aug 29 20:46:51 2018 Revert "Check that mask to path fallback happens" This reverts commit 9f85b5116e333a65ecfecb66adfdf7f72bb9e9ef. Reason for revert: triggers tsan by tickling a DDL problem See bug skia:8324 Original change's description: > Check that mask to path fallback happens > > BUG= chromium:876767 > > Change-Id: I6aadf329af836a1e03aa85b34a58830be00ff750 > Reviewed-on: https://skia-review.googlesource.com/150135 > Commit-Queue: Herb Derby <herb@google.com> > Reviewed-by: Khusal Sagar <khushalsagar@chromium.org> TBR=herb@google.com,khushalsagar@chromium.org,khushalsagar@google.com Change-Id: I45155a8b9f4412082eb5f60223ab68f574d625b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:876767 Reviewed-on: https://skia-review.googlesource.com/150369 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com> [modify] https://crrev.com/eb0bb732f43fdf7f8cf74a68579ee11da1c987f5/src/core/SkGlyphRun.cpp [modify] https://crrev.com/eb0bb732f43fdf7f8cf74a68579ee11da1c987f5/src/core/SkGlyphRun.h [modify] https://crrev.com/eb0bb732f43fdf7f8cf74a68579ee11da1c987f5/tests/SkRemoteGlyphCacheTest.cpp
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca1cca8e3afc5fdb10466c839330b9a73feeafb5 commit ca1cca8e3afc5fdb10466c839330b9a73feeafb5 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Aug 29 22:41:21 2018 Roll src/third_party/skia a81c2be75adc..eb0bb732f43f (26 commits) https://skia.googlesource.com/skia.git/+log/a81c2be75adc..eb0bb732f43f git log a81c2be75adc..eb0bb732f43f --date=short --no-merges --format='%ad %ae %s' 2018-08-29 herb@google.com Revert "Check that mask to path fallback happens" 2018-08-29 mtklein@google.com Revert "Use skcms_PrimariesToXYZD50 to implement SkColorSpacePrimaries::toXYZD50" 2018-08-29 robertphillips@google.com Revert "Always force GPU generated masks be top left" 2018-08-29 herb@google.com Managing the context was dropped. Adding back in. 2018-08-29 brianosman@google.com Use skcms_PrimariesToXYZD50 to implement SkColorSpacePrimaries::toXYZD50 2018-08-29 bsalomon@google.com Fix GrGLGpu::createTestingOnlyBackendRenderTarget() 2018-08-29 herb@google.com Check that mask to path fallback happens 2018-08-29 kjlubick@google.com [LottieWeb] Fix frames 2018-08-29 mtklein@google.com fix two 1-bit mismatches in sRGB transfer functions 2018-08-29 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 94d4660dd3f1..60f8662dc0ef (3 commits) 2018-08-29 robertphillips@google.com Always force GPU generated masks be top left 2018-08-29 herb@google.com Add an empty typeface for testing 2018-08-29 allanmac@google.com Update HotSort cl/vk. 2018-08-29 benjaminwagner@google.com [infra] Update Win Radeon drivers. 2018-08-29 benjaminwagner@google.com Update NVIDIA_Shield to Oreo. 2018-08-29 reed@google.com clean up for removing drawTextOnPath from canvas 2018-08-29 csmartdalton@google.com Add a tolerance to SkRemoteGlyphCache_DrawTextAsPath 2018-08-29 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms da25e1a6d412..6b324dbdf772 (1 commits) 2018-08-29 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 5f03dc9abfb1..da25e1a6d412 (1 commits) 2018-08-29 bsalomon@google.com Temporarily make SkTMultiMap::remove() safe for values not in map 2018-08-29 kjlubick@google.com Correct LottieWeb drawing params 2018-08-29 reed@google.com textonpath no longer in canvas 2018-08-29 michaelludwig@google.com Add setXi and setXiv in GrGLSLProgramDataManager. 2018-08-29 kjlubick@google.com [PathKit] Make pathops assertion a little more forgiving 2018-08-29 brianosman@google.com Remove unused onCanLazyGenerateOnGPU function 2018-08-29 reed@google.com Revert "fix g3 by adding legacy flag" Created with: gclient setdep -r src/third_party/skia@eb0bb732f43f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:876767 , chromium:878195 ,chromium:877611, chromium:876767 , chromium:878195 ,chromium:877915 TBR=stephana@chromium.org Change-Id: I312b4a2f488d247a3d7d4bf79453855767290c47 Reviewed-on: https://chromium-review.googlesource.com/1195867 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587342} [modify] https://crrev.com/ca1cca8e3afc5fdb10466c839330b9a73feeafb5/DEPS
,
Aug 30
Latest CT run shows everything is fixed. \o/
,
Aug 30
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 30
Removing merge label.
,
Aug 30
Right, we are just branching this AM, it made it before 70 branch cut.
,
Aug 30
The following revision refers to this bug: https://skia.googlesource.com/skia/+/8e318fda76dfdd2cc6be3a79ac1296278a3d43c6 commit 8e318fda76dfdd2cc6be3a79ac1296278a3d43c6 Author: Herb Derby <herb@google.com> Date: Thu Aug 30 19:34:13 2018 Reland "Check that mask to path fallback happens" This is a reland of 9f85b5116e333a65ecfecb66adfdf7f72bb9e9ef Original change's description: > Check that mask to path fallback happens > > BUG= chromium:876767 > > Change-Id: I6aadf329af836a1e03aa85b34a58830be00ff750 > Reviewed-on: https://skia-review.googlesource.com/150135 > Commit-Queue: Herb Derby <herb@google.com> > Reviewed-by: Khusal Sagar <khushalsagar@chromium.org> Bug: chromium:876767 Change-Id: I3fdf17ef3bd9c3f8b0e19d017f14114f3675dc12 Reviewed-on: https://skia-review.googlesource.com/150544 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Herb Derby <herb@google.com> [modify] https://crrev.com/8e318fda76dfdd2cc6be3a79ac1296278a3d43c6/src/core/SkGlyphRun.cpp [modify] https://crrev.com/8e318fda76dfdd2cc6be3a79ac1296278a3d43c6/src/core/SkGlyphRun.h [modify] https://crrev.com/8e318fda76dfdd2cc6be3a79ac1296278a3d43c6/tests/SkRemoteGlyphCacheTest.cpp
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f406bd5cb2a02810305c8d7b67b3cc85ad7c5a55 commit f406bd5cb2a02810305c8d7b67b3cc85ad7c5a55 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Aug 31 19:00:11 2018 Roll src/third_party/skia 7ed0eae0cd13..9951cbf4ca79 (58 commits) https://skia.googlesource.com/skia.git/+log/7ed0eae0cd13..9951cbf4ca79 git log 7ed0eae0cd13..9951cbf4ca79 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms a6687f8b4d51..80e0493eab5f (1 commits) 2018-08-31 mtklein@google.com update CPU feature macros in src/opts 2018-08-31 khushalsagar@chromium.org fonts: Cap the max number of entries in server side glyph cache tracking 2018-08-31 brianosman@google.com Add support for gray + colorspace to SkCodec 2018-08-31 herb@google.com Extract SkGlyphRunListPainter from SkGlyphRun.* 2018-08-31 mtklein@google.com Reland "standardize macro checks in SkRasterPipeline_opts" 2018-08-31 ethannicholas@google.com fixed uninitialized memory use in arithmetic effect 2018-08-31 bsalomon@google.com Make GrSemaphore a GrGpuResource 2018-08-31 mtklein@google.com Revert "standardize macro checks in SkRasterPipeline_opts" 2018-08-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 018002b16a8a..a6687f8b4d51 (1 commits) 2018-08-31 michaelludwig@google.com Refactor 'in uniform' CPP code generation 2018-08-31 fmalita@chromium.org [skottie] SkTArray begone 2018-08-31 benjaminwagner@google.com Move gbr-gl config from GTX1070 to QuadroP400. 2018-08-31 kjlubick@google.com [PathKit] Remove experimental- from package names 2018-08-31 mtklein@google.com update SkPreConfig a little 2018-08-31 mtklein@google.com standardize macro checks in SkRasterPipeline_opts 2018-08-31 csmartdalton@google.com Revert "ccpr: Implement stroking with fine triangle strips" 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 kjlubick@google.com [PathKit] Move from experimental to modules 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 egdaniel@google.com Add support for switching family queues in vulkan. 2018-08-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms b116880ba8e8..018002b16a8a (1 commits) 2018-08-31 mtklein@google.com Revert "update SkPaint size sanity check" 2018-08-31 csmartdalton@google.com ccpr: Implement stroking with fine triangle strips 2018-08-31 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 5ac66b04c9e3..b116880ba8e8 (1 commits) 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 robertphillips@google.com Fix Fuchsia roll 2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-31 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 1bf963b62929..fd1621076a74 (1 commits) 2018-08-31 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 62cfbb9c7876..5fb5e817a20d (1 commits) 2018-08-30 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4bbff9eb88c1..62cfbb9c7876 (2 commits) 2018-08-30 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 44b2c0b1d349..1bf963b62929 (1 commits) 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-30 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 6b324dbdf772..5ac66b04c9e3 (1 commits) 2018-08-30 mtklein@google.com Another manual ANGLE roll 2018-08-30 bungeman@google.com Detect when a FreeType glyph doesn't have a path. 2018-08-30 michaelludwig@google.com Support input color argument to process() function in sksl .fp files 2018-08-30 michaelludwig@google.com Remove GrTextureStripAtlas, textured gradients use independent textures 2018-08-30 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 60f8662dc0ef..4bbff9eb88c1 (1 commits) 2018-08-30 herb@google.com Remove drawPosText from SkDevice 2018-08-30 herb@google.com Reland "Check that mask to path fallback happens" 2018-08-30 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ddc41208c15f..e1037e9be377 (5 commits) 2018-08-30 michaelludwig@google.com Improve inputColor handling in fragment processor implementations. 2018-08-30 herb@google.com Remove drawPosText from svg 2018-08-30 herb@google.com Remove drawPosText_asPath - more dead code 2018-08-30 kjlubick@google.com [Skottie] Fallback to portable font manager 2018-08-30 hcm@google.com Update Skia milestone to 71 2018-08-30 bsalomon@google.com Some GrSemaphore cleanup 2018-08-30 robertphillips@google.com Suppress addition of changeListeners during DDL recording 2018-08-30 herb@google.com Remove drawPosText support for SkBitmapDevice 2018-08-30 ethannicholas@google.com converted arithmetic FP to new FP structure 2018-08-30 robertphillips@google.com Always force GPU generated masks be top left (take 2) 2018-08-30 caryclark@skia.org remove scaling from pathops 2018-08-30 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-30 egdaniel@google.com Fix vulkan validation layer ordering. 2018-08-30 mtklein@google.com roll ANGLE w/ GN update 2018-08-30 kjlubick@google.com Add FuzzPathop to oss-fuzz Created with: gclient setdep -r src/third_party/skia@9951cbf4ca79 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878966, chromium:876767 , chromium:878195 TBR=stephana@chromium.org Change-Id: I27daf0f7bd593680846006414e16f44b47182f8d Reviewed-on: https://chromium-review.googlesource.com/1199688 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588104} [modify] https://crrev.com/f406bd5cb2a02810305c8d7b67b3cc85ad7c5a55/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by khushals...@chromium.org
, Aug 22