New issue
Advanced search Search tips

Issue 876758 link

Starred by 2 users
Status: Fixed
Owner:
lgrey@chromium.org
Closed: Aug 28
Cc:
ellyjo...@chromium.org
jonr...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DragDropClientMacTest.ReleaseCapture Flaky Semi-Regularly

Project Member Reported by jonr...@chromium.org, Aug 22 
OS: Mac
Test: views_unittests
Bot: mac_chromium_rel_ng

The first failure occurs on this tryjob: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/123838

However it also fails without the patch.

I suspect this change to drag/drop which landed before that run: https://chromium-review.googlesource.com/c/chromium/src/+/1183991


lgrey@ could you please take a look? If it is not you could you help triage?

I can look at disabling is there isn't a quick fix

Comment 1 by jonr...@chromium.org, Aug 22 

The patch was reverted in: https://chromium.googlesource.com/chromium/src/+/a9ede5790d2586963ae201a308639c973d90048c

So this is no longer blocking changes from landing.,

Comment 2 by jonr...@chromium.org, Aug 22 

 Issue 876771  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa7f8f7988c82503dd0e16bedc51166dabf5fa4b

commit fa7f8f7988c82503dd0e16bedc51166dabf5fa4b
Author: Leonard Grey <lgrey@chromium.org>
Date: Wed Aug 22 19:54:13 2018

Add a drag image in DragDropClientMacTest.ReleaseCapture

https://chromium-review.googlesource.com/c/chromium/src/+/1183991 added
an early exit for drags without drag images to prevent a crash on Mojave.

DragDropClientMacTest.ReleaseCapture posts a task to end a drag before
starting the drag. Since the drag data it was providing had no image,
the drag was exiting before the task could post, making the EndDrag()
posted by the task a UAF.

This change adds an image to the drag data to prevent this.

Bug: 876201, 876758 
Change-Id: Icbdd38ff65a690fdb7f7512a8686c2e3d4344286
Reviewed-on: https://chromium-review.googlesource.com/1185219
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585213}
[modify] https://crrev.com/fa7f8f7988c82503dd0e16bedc51166dabf5fa4b/ui/views/cocoa/drag_drop_client_mac_unittest.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c66d20a6deb8381885cda411ce36e03798458d5

commit 5c66d20a6deb8381885cda411ce36e03798458d5
Author: Leonard Grey <lgrey@chromium.org>
Date: Mon Aug 27 15:20:40 2018

Add a drag image in DragDropClientMacTest.ReleaseCapture

https://chromium-review.googlesource.com/c/chromium/src/+/1183991 added
an early exit for drags without drag images to prevent a crash on Mojave.

DragDropClientMacTest.ReleaseCapture posts a task to end a drag before
starting the drag. Since the drag data it was providing had no image,
the drag was exiting before the task could post, making the EndDrag()
posted by the task a UAF.

This change adds an image to the drag data to prevent this.

Bug: 876201, 876758 
Change-Id: Icbdd38ff65a690fdb7f7512a8686c2e3d4344286
Reviewed-on: https://chromium-review.googlesource.com/1185219
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#585213}(cherry picked from commit fa7f8f7988c82503dd0e16bedc51166dabf5fa4b)
Reviewed-on: https://chromium-review.googlesource.com/1190404
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#812}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/5c66d20a6deb8381885cda411ce36e03798458d5/ui/views/cocoa/drag_drop_client_mac_unittest.mm

Comment 5 by lgrey@chromium.org, Aug 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment