New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876755 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression



Sign in to add a comment

depot_tools auto-roller has created a lot of identical-looking roll CLs, and not cleaned them up.

Project Member Reported by w...@chromium.org, Aug 22

Issue description

Visiting a CL that touches DEPS, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1185020 I see a huge list of conflicts in the Gerrit UI, all of which are for identical-looking depot_tools rolls.

Many of the roll CLs are old (>days), so should have been tidied up by the autoroller.  IIUC that is done via a daily job that just closes-out old roll CLs by listing all outstanding CLs under the auto-roller account, so it seems that that process is not running, or is failing for some reason?
 
Owner: bore...@google.com
Status: Started (was: Untriaged)
Hrm, yeah, the roller is supposed to clean up after itself.  It scans for old CLs every hour and closes those older than a week.  I'll take a look.
There was some kind of outage so perhaps that job just wasn't able to make progress?
Ah, I see what's going on.  I've been performing some major changes to the autorollers lately.  We had a problem a couple of weeks ago where some of the rollers started running as the GCE default service account for our project, instead of the correct account for that roller.  The depot tools roller was one of them.  The offending CLs are from the default service account: https://chromium-review.googlesource.com/q/owner:31977622648%2540project.gserviceaccount.com  They're "orphaned" and not being cleaned up because each roller is looking for CLs from its own account.

I'll clean them up manually.
Status: Fixed (was: Started)
Okay, the offending CLs have been removed.  Sorry for the inconvenience!

Sign in to add a comment