New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876750 link

Starred by 0 users

Issue metadata

Status: Duplicate
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Indicate that the keyboard accessory is part of Chromium

Project Member Reported by fhorschig@chromium.org, Aug 22

Issue description

Currently, it can be hard for users to figure out that the keyboard accessory is part of Chrome (esp. as opposed to being part of their keyboard).

To indicate that this the case, add some kind of branding, e.g. a logo in the accessory or incorporate the "Powered by Chrome" string at some place.
 

Comment 1 Deleted

Status: Assigned (was: Started)
Labels: -M-70 M-72
The UX rework will fix that: consistent style with Omnibar and in-product help will emphasize that this is part of Chrome.
This won't happen before 72/73 and a "fix" like a string or a logo wasn't deemed appropriate.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a562f181201b1650f282144256c4894135457be7

commit a562f181201b1650f282144256c4894135457be7
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Nov 19 10:36:02 2018

[Mfill Android] Apply v2 style on keyboard accessory

This CL introduces the new style of the keyboard accessory (clean white)
to highlight is as part of the Chrome UI. It's also the base for IPH
which will explicitly state the origin of suggestions and actions.

Because the new design uses autofill suggestions as integral part, it is
guarded by the #autofill-keyboard-accessory-view flag which isn't used
in other way anymore.

To keep the old implementation until the new design is fully approved
and fleshed out, the KeyboardAccessoryModernView* classes extend the
existing classes and replace them if the appropriate flags are set.

For screenshots highlighting the differences, see:
go/keyboard-accessory-v2

Bug: 853772,  876750 
Change-Id: I44718a4e2269d17b002d7dc890784a847ed840e7
Reviewed-on: https://chromium-review.googlesource.com/c/1338087
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609230}
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/drawable/ic_keyboard.xml
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/layout/keyboard_accessory_modern.xml
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/layout/keyboard_accessory_suggestion.xml
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/layout/keyboard_accessory_tabs.xml
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModernView.java
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModernViewBinder.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryProperties.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java_sources.gni
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/browser/about_flags.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/browser/password_manager/password_accessory_metrics_util.h
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_util.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_util.h

Mergedinto: 911084
Status: Duplicate (was: Assigned)
(This is planned to be fixed with the white design + FRE)

Sign in to add a comment