Small fix-ups Q3 2018 |
|||
Issue descriptionTracking little CLs
,
Aug 25
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/ec345092dd8d98d491c28c7d60d9edd2bd61d920 commit ec345092dd8d98d491c28c7d60d9edd2bd61d920 Author: Simon Glass <sjg@chromium.org> Date: Sat Aug 25 05:16:54 2018 chip/npcx: Make check_reset_cause() static This function is not called from outside this file so make it static. Also drop a pointless comment, and rename the function since the 'system' prefix suggests it is defined in system.h (which it is not). BUG= chromium:876737 BRANCH=none TEST=make -j50 BOARD=grunt Change-Id: Ic429fb1da2e56e1888e008f4739c90e8ed2c1947 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1184975 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> [modify] https://crrev.com/ec345092dd8d98d491c28c7d60d9edd2bd61d920/chip/npcx/system.c
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/e192f71aed932b88f3c42df4653a430a2e8ba10e commit e192f71aed932b88f3c42df4653a430a2e8ba10e Author: Simon Glass <sjg@chromium.org> Date: Wed Sep 05 04:03:57 2018 chip/npcx: Tidy up comments for init_hw_timer() The comments suggest that this function only operates with ITIM16 timers but it seems to support ITIM32 as well. Also it allows selecting the clock source. Update the comments, hopefully making them correct. BUG= chromium:876737 BRANCH=none TEST= make buildall -j50 Change-Id: Ic4ec2457cde2de55d51371f781d49bae80365989 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1185225 [modify] https://crrev.com/e192f71aed932b88f3c42df4653a430a2e8ba10e/chip/npcx/hwtimer.c [modify] https://crrev.com/e192f71aed932b88f3c42df4653a430a2e8ba10e/chip/npcx/hwtimer_chip.h
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/4c1841b9f30a733c3bcb5fc5ed9b9bf3d7d61c19 commit 4c1841b9f30a733c3bcb5fc5ed9b9bf3d7d61c19 Author: Simon Glass <sjg@chromium.org> Date: Wed Sep 05 04:03:58 2018 hwtimer: Tidy up and clarify some hw_clock comments From what I can tell the counter has to tick over at the rate of 1MHz. Update the comments to make that clear. BUG= chromium:876737 BRANCH=none TEST= make buildall -j50 Change-Id: Ib04731c10a68c544973b810cf70ce9ffba556b89 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1185230 [modify] https://crrev.com/4c1841b9f30a733c3bcb5fc5ed9b9bf3d7d61c19/include/hwtimer.h
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/9173b1eb0cc11e71051521e34c397d3653950419 commit 9173b1eb0cc11e71051521e34c397d3653950419 Author: Simon Glass <sjg@chromium.org> Date: Thu Sep 06 18:39:49 2018 chip/npcx: Tidy up comments for init_hw_timer() The comments suggest that this function only operates with ITIM16 timers but it seems to support ITIM32 as well. Also it allows selecting the clock source. Update the comments, hopefully making them correct. BUG= chromium:876737 BRANCH=none TEST= make buildall -j50 Change-Id: Ic4ec2457cde2de55d51371f781d49bae80365989 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1185225 (cherry picked from commit e192f71aed932b88f3c42df4653a430a2e8ba10e) Reviewed-on: https://chromium-review.googlesource.com/1211362 Reviewed-by: Martin Roth <martinroth@chromium.org> Commit-Queue: Martin Roth <martinroth@chromium.org> Tested-by: Martin Roth <martinroth@chromium.org> [modify] https://crrev.com/9173b1eb0cc11e71051521e34c397d3653950419/chip/npcx/hwtimer.c [modify] https://crrev.com/9173b1eb0cc11e71051521e34c397d3653950419/chip/npcx/hwtimer_chip.h
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/dab97b3d536aaa42b8a4ca7afed213ccc103d5b1 commit dab97b3d536aaa42b8a4ca7afed213ccc103d5b1 Author: Simon Glass <sjg@chromium.org> Date: Tue Sep 18 15:38:06 2018 hwtimer: Tidy up and clarify some hw_clock comments From what I can tell the counter has to tick over at the rate of 1MHz. Update the comments to make that clear. BUG= chromium:876737 BRANCH=none TEST= make buildall -j50 Change-Id: Ib04731c10a68c544973b810cf70ce9ffba556b89 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1185230 Reviewed-on: https://chromium-review.googlesource.com/1230978 Reviewed-by: Martin Roth <martinroth@chromium.org> Commit-Queue: Martin Roth <martinroth@chromium.org> Tested-by: Martin Roth <martinroth@chromium.org> [modify] https://crrev.com/dab97b3d536aaa42b8a4ca7afed213ccc103d5b1/include/hwtimer.h
,
Oct 2
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sjg@chromium.org
, Aug 22Status: Started (was: Untriaged)