New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876731 link

Starred by 1 user
Status: Fixed
Owner:
█ akaba@chromium.org
Last visit > 30 days ago
Closed: Aug 23
Cc:
samans@chromium.org
█ fsam...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update surface_aggregator_unittest.cc and surface_synchronization_unittest.cc to use SurfaceRanges

Project Member Reported by akaba@chromium.org, Aug 22 
SurfaceQuad in surface_aggregator_unittest.cc should take a SurfaceRange
and GetLatestInFlightSurface in surface_synchronization_unittest.cc should take a SurfaceRange.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc32445df16acf82f40643689e693ec8515de45

commit 6bc32445df16acf82f40643689e693ec8515de45
Author: akaba <akaba@google.com>
Date: Thu Aug 23 23:46:28 2018

Cleanup surface_aggregator_unittest.cc and surface_synchronization_unittest.cc

The unit tests should start using SurfaceRanges instead of two SurfaceIds for
simplicity.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If6d41f07d9f4735399e990aca9c4a8e93449324a
Bug:  876731 
Reviewed-on: https://chromium-review.googlesource.com/1184226
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585660}
[modify] https://crrev.com/6bc32445df16acf82f40643689e693ec8515de45/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/6bc32445df16acf82f40643689e693ec8515de45/components/viz/service/frame_sinks/surface_synchronization_unittest.cc

Comment 2 by akaba@chromium.org, Aug 23

Status: Fixed (was: Assigned)
►

Sign in to add a comment