Pixel gap above Omnibox |
||
Issue descriptionChrome Version : 70.0.3524.2 OS Version: 10984.0.0 What steps will reproduce the problem? 1. Enable chrome://flags/#upcoming-ui-features flag 2. Set display size to 220% in Chrome Display Settings What is the expected result? Omnibox should look great What happens instead of that? There is a 1px gap above the Omnibox. See screenshots attached.
,
Aug 22
FWIW I can repro this on Windows at 220%, though it's much more subtle for whatever reason. The issue is that the right path in GetRefreshInteriorPath() starts at 'bottom' instead of 'extended_bottom'. Introduced in https://crrev.com/c/1171917.
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/045646225cbd23a0eb55c73efc204636e82a5dd3 commit 045646225cbd23a0eb55c73efc204636e82a5dd3 Author: Taylor Bergquist <tbergquist@chromium.org> Date: Fri Aug 24 20:30:18 2018 Fix bottom right tab painting in high dpi. Tabs currently draw a one-DIP overlap into the toolbar to correct for alignment issues in non-integer DPI scales. This regressed recently (in crrev.com/c/1171917) on just the right side. This CL restores the old behavior. Bug: 876730 Change-Id: I524b87af63359b507081ce9f0814ab8c8a3e17f6 Reviewed-on: https://chromium-review.googlesource.com/1186140 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585967} [modify] https://crrev.com/045646225cbd23a0eb55c73efc204636e82a5dd3/chrome/browser/ui/views/tabs/tab.cc
,
Aug 24
|
||
►
Sign in to add a comment |
||
Comment 1 by tommycli@chromium.org
, Aug 22