New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876728 link

Starred by 1 user
Status: WontFix
Owner:
samans@chromium.org
Closed: Sep 13
Cc:
samans@chromium.org
█ fsam...@chromium.org
kylec...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

HostFrameSinkManger::EvictSurfaces no longer makes sense

Project Member Reported by fsam...@chromium.org, Aug 22 
EvictSurfaces evicts individual SurfaceIds but with the new SurfaceRange mechanism, the last activated surface might not be the surface the client is currently embedding or has a reference to.

Perhaps we should have an EvictLatestInFlightSurface(SurfaceRange)?

Comment 1 by akaba@chromium.org, Aug 22

Cc: -akaba@chromium.org fsam...@chromium.org
Owner: akaba@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by fsam...@chromium.org, Aug 26

Owner: samans@chromium.org

Comment 3 by samans@chromium.org, Sep 13

Status: WontFix (was: Assigned)
The last activated surface is the only surface that we would possibly want to evict. Older surfaces don't need to be evicted, and there is no newer surface. Every time a surface is activated, the host is notified and sends another evict message. I don't think this change is necessary. Please reopen (and clarify with an example) if I'm wrong.

Comment 4 by fsam...@chromium.org, Sep 13 

What do you mean there's no newer surface? We don't send another evict message OnFirstSurfaceActivation. Am I missing something? I'm confused.

Comment 5 by samans@chromium.org, Sep 13 

Every time a surface activates we notify frame evictor which would call evict if necessary.

Comment 6 by fsam...@chromium.org, Sep 13 

Ohh I see! OK nevermind!
►

Sign in to add a comment