New issue
Advanced search Search tips

Issue 876720 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

authpolicy: Use D-Bus bindings

Project Member Reported by ljusten@chromium.org, Aug 22

Issue description

Use generated bindings for SessionManagerClient and CryptohomeClient.
 
Example: http://cs/chromeos_public/src/platform2/dlcservice/
Look for the "...InterfaceProxyInterface" types (might be missing some includes for them in dlc_service.cc).

https://chromium.googlesource.com/aosp/platform/external/dbus-binding-generator/+/master/README.md has some information about the generated code.
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ce127920505e411076c85250812cf0437893dc16

commit ce127920505e411076c85250812cf0437893dc16
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Dec 12 03:33:48 2018

authpolicy: Use generated client bindings

Uses the generated D-Bus bindings of the SessionManager and Cryptohome
clients. So far, authpolicy has been doing the parameter marshalling
itself. This CL just reduces code size, but does not introduce any
significant behavioral change.

CQ-DEPEND=CL:1370051

BUG=chromium:909719
TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy

Change-Id: Ic8ee60d5976be1ea2922f9b44c7b250bf0d5f7fd
Reviewed-on: https://chromium-review.googlesource.com/1369795
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/ce127920505e411076c85250812cf0437893dc16/authpolicy/cryptohome_client.h
[modify] https://crrev.com/ce127920505e411076c85250812cf0437893dc16/authpolicy/session_manager_client.cc
[modify] https://crrev.com/ce127920505e411076c85250812cf0437893dc16/authpolicy/session_manager_client.h
[modify] https://crrev.com/ce127920505e411076c85250812cf0437893dc16/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/ce127920505e411076c85250812cf0437893dc16/authpolicy/cryptohome_client.cc
[modify] https://crrev.com/ce127920505e411076c85250812cf0437893dc16/authpolicy/authpolicy.cc
[modify] https://crrev.com/ce127920505e411076c85250812cf0437893dc16/authpolicy/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7dd96d8d396ce48aca21c547908def6412c6e4d1

commit 7dd96d8d396ce48aca21c547908def6412c6e4d1
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Dec 12 03:33:48 2018

authpolicy: Depend on {cryptohome,session_manager}-client

This CL enables using the dbus clients in authpolicy, see dependent CL.
Right now, authpolicy still does the parameter marshalling itself.

CQ-DEPEND=CL:1369795

BUG=chromium:909719
TEST=cros_run_unit_tests --board=amd64-generic --packages authpolicy

Change-Id: Ibbfef59908380963a4e00e6e26496f6e096844f1
Reviewed-on: https://chromium-review.googlesource.com/1370051
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/7dd96d8d396ce48aca21c547908def6412c6e4d1/chromeos-base/authpolicy/authpolicy-9999.ebuild

Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/590af628c50a103e6482488bc8ff4ae938d34866

commit 590af628c50a103e6482488bc8ff4ae938d34866
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Dec 19 05:33:33 2018

authpolicy: Fix CryptohomeClient crash

Reverts the CryptohomeClient part of
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1369795
since the autogenerated CryptohomeInterfaceProxy is broken. It uses
"/org/chromium/" as object path (from the node name in
org.chromium.CryptohomeInterface.xml), but Cryptohome actually uses
"/org/chromium/Cryptohome" (from kCryptohomeServicePath in
dbus-constants).

Since it's not possible to override that object path and I'm not sure
what impact would changing the node name in the xml file would have, it
is safer to just revert the CryptohomeClient change.

See also chromium:916083

BUG=chromium:909719
TEST=Tested on device

Change-Id: I0924983582d3906d24dd3d8e11a8e1e74706fc11
Reviewed-on: https://chromium-review.googlesource.com/1382214
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>

[modify] https://crrev.com/590af628c50a103e6482488bc8ff4ae938d34866/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/590af628c50a103e6482488bc8ff4ae938d34866/authpolicy/cryptohome_client.cc
[modify] https://crrev.com/590af628c50a103e6482488bc8ff4ae938d34866/authpolicy/cryptohome_client.h

Sign in to add a comment