New issue
Advanced search Search tips

Issue 876717 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue gerrit:9640



Sign in to add a comment

Roll new wpt tools including manifest version change

Project Member Reported by foolip@chromium.org, Aug 22

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b287a61d952026a84421b51f61859ccfa263929

commit 4b287a61d952026a84421b51f61859ccfa263929
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Wed Aug 22 21:59:23 2018

Always start from WPT_BASE_MANIFEST.json when updating MANIFEST.json

This will avoid full manifest rebuilds for Chromium developers when
the manifest version changes.

Bug:  876717 
Change-Id: I6d552ad03936fb07cf559d0f072508e5ea2184a4
Reviewed-on: https://chromium-review.googlesource.com/1185009
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585271}
[modify] https://crrev.com/4b287a61d952026a84421b51f61859ccfa263929/third_party/blink/tools/blinkpy/common/host_mock.py
[modify] https://crrev.com/4b287a61d952026a84421b51f61859ccfa263929/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py
[modify] https://crrev.com/4b287a61d952026a84421b51f61859ccfa263929/third_party/blink/tools/blinkpy/w3c/wpt_manifest_unittest.py

Blockedon: gerrit:9640
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2010d30c56141545622dd8655230caa16dcf6aec

commit 2010d30c56141545622dd8655230caa16dcf6aec
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Aug 31 14:45:23 2018

Rename WPT_BASE_MANIFEST.json to WPT_BASE_MANIFEST_4.json

Gerrit has trouble with very large diffs and
https://chromium-review.googlesource.com/c/chromium/src/+/1183425 has
not been possible to land for over a week.

As a workaround, put the manifest version in the base manifest file
name. When the manifest version changes, at least this time, we'll add
WPT_BASE_MANIFEST_5.json, update the code to use that, and then later
remove WPT_BASE_MANIFEST_4.json.

Bug:  876717 
Change-Id: I98c5cae3bb650daae347d20fc2c83817e91e726b
Reviewed-on: https://chromium-review.googlesource.com/1196405
Reviewed-by: Luke Bj <lukebjerring@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588022}
[rename] https://crrev.com/2010d30c56141545622dd8655230caa16dcf6aec/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_4.json
[modify] https://crrev.com/2010d30c56141545622dd8655230caa16dcf6aec/third_party/blink/tools/blinkpy/common/host_mock.py
[modify] https://crrev.com/2010d30c56141545622dd8655230caa16dcf6aec/third_party/blink/tools/blinkpy/w3c/test_importer.py
[modify] https://crrev.com/2010d30c56141545622dd8655230caa16dcf6aec/third_party/blink/tools/blinkpy/w3c/test_importer_unittest.py
[modify] https://crrev.com/2010d30c56141545622dd8655230caa16dcf6aec/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da61e62dd5548951563e795de683e00701e4e7e3

commit da61e62dd5548951563e795de683e00701e4e7e3
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Aug 31 16:37:33 2018

Roll in new version of WPT tools

Mainly for the .serviceworker. change in tools/manifest/item.py, from
https://github.com/web-platform-tests/wpt/pull/12381

port/driver.py is updated accordingly to match upstream wptrunner to
use HTTPS for .serviceworker. tests. This fixes an infrastructure/
test. Multiple other .serviceworker. tests are also rebaselined.

There have been two recent manifest changes:
https://github.com/web-platform-tests/wpt/pull/12182
https://github.com/web-platform-tests/wpt/pull/12563 (version bump)

In order to not require a full manifest rebuild once this lands,
WPT_BASE_MANIFEST.json needs to be updated. However, updating it in
place has proven very difficult due to the size of the resulting
diff. Instead, a WPT_BASE_MANIFEST_5.json is created. The old one will
be deleted separately. Related Gerrit bug:
https://bugs.chromium.org/p/gerrit/issues/detail?id=9640

This also brings in HTTP/2.0 support from
https://github.com/web-platform-tests/wpt/pull/12193.

For this, new third_party python code is needed, namely h2, hpack,
hyperframe, and enum.

In addition to adding those to WPTWhiteList, it is also sorted and
lines which aren't existing files (i.e., directories and removed
files) are dropped.

Reviewed at https://chromium-review.googlesource.com/1183425 but size
of CL causing trouble updating it on Gerrit.

TBR=robertma@chromium.org

Bug:  876717 
Change-Id: Ia43bd2eca54883a5d72a48008b6677d0e7187056
Reviewed-on: https://chromium-review.googlesource.com/1196424
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588057}
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/idlharness.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/backpressure.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/decode-bad-chunks.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/decode-ignore-bom.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/decode-incomplete-input.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/decode-non-utf8.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/decode-split-character.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/decode-utf8.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/encode-bad-chunks.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/encode-utf8.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/encoding/streams/readable-writable-properties.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/fetch/api/abort/general.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/fetch/api/basic/header-value-null-byte.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/fetch/api/idl.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-stream.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/fetch/api/response/response-from-stream.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/fetch/cors-rfc1918/idlharness.tentative.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/fetch/cross-origin-resource-policy/fetch.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/hr-time/idlharness.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/microtask-queuing/queue-microtask-exceptions.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/microtask-queuing/queue-microtask.any.serviceworker-expected.txt
[delete] https://crrev.com/8c93e4bf348b44b8e3824f7392efc0ddfc41fe44/third_party/WebKit/LayoutTests/external/wpt/notifications/idlharness.https.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/performance-timeline/idlharness.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/user-timing/idlharness.any.serviceworker-expected.txt
[rename] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/WebKit/LayoutTests/external/wpt/websockets/basic-auth.any.serviceworker-expected.txt
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/common/host_mock.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/README.chromium
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/README.chromium
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/WPTWhiteList
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/checkout.sh
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/localpaths.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/item.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/manifest.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/sourcefile.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/vcs.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/serve/__init__.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/serve/serve.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/enum/enum/LICENSE
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/enum/enum/README
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/enum/enum/__init__.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/LICENSE
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/__init__.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/config.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/connection.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/errors.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/events.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/exceptions.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/frame_buffer.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/settings.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/stream.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/utilities.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/h2/h2/windows.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/LICENSE
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/__init__.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/compat.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/exceptions.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/hpack.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/huffman.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/huffman_constants.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/huffman_table.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/struct.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hpack/hpack/table.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hyperframe/LICENSE
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hyperframe/hyperframe/__init__.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hyperframe/hyperframe/exceptions.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hyperframe/hyperframe/flags.py
[add] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/third_party/hyperframe/hyperframe/frame.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/run.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/testfiles.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/config.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/constants.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/request.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/response.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/router.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/server.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/__init__.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/sslutils/openssl.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/stash.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wptserve/wptserve/utils.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/web_tests/port/driver.py
[modify] https://crrev.com/da61e62dd5548951563e795de683e00701e4e7e3/third_party/blink/tools/blinkpy/web_tests/port/driver_unittest.py

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a0de499a588d5d9c75007794571c5edd7de38e2

commit 6a0de499a588d5d9c75007794571c5edd7de38e2
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Mon Sep 17 16:23:26 2018

Delete WPT_BASE_MANIFEST_4.json

This is cleanup following the addition of WPT_BASE_MANIFEST_5.json.

Bug:  876717 
Change-Id: Ic1293306f7aed9483666ed6ca24976a2da45a898
Reviewed-on: https://chromium-review.googlesource.com/1227116
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591702}
[delete] https://crrev.com/96f850f7d81dcc52a4f429a54c83b9f39975fb5e/third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_4.json

Sign in to add a comment