New issue
Advanced search Search tips

Issue 876716 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Aug 24
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Tapping the status bar shouldn't scroll the WebView to the top when the toolbar is collapsed

Project Member Reported by gambard@chromium.org, Aug 22 
What steps will reproduce the problem?
(1) Scroll a page to enter fullscreen
(2) Tap on the status bar

What is the expected result?
The user should exit fullscreen without changing the scroll offset.

What happens instead?
The page is scrolled to the top (and exit fullscreen, as expected).
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46d832ccbcd08a729286f6f95986eb044fcb358f

commit 46d832ccbcd08a729286f6f95986eb044fcb358f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Aug 24 08:55:25 2018

[iOS] Do not scroll to top when in fullscreen

This CL disable the "scroll to top" action when tapping the status bar
when fullscreen is enabled.

Bug:  876716 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If2a199be39da0de596e8d945e9fc4c42c65ad009
Reviewed-on: https://chromium-review.googlesource.com/1185098
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585766}
[modify] https://crrev.com/46d832ccbcd08a729286f6f95986eb044fcb358f/ios/chrome/browser/ui/fullscreen/fullscreen_web_view_proxy_observer.mm

Comment 2 by gambard@chromium.org, Aug 24

Status: Fixed (was: Assigned)

Comment 3 by vbarig...@chromium.org, Aug 29

Status: Verified (was: Fixed)
Verified on chrome canary version 70.0.3536.0 on iPhone 6/6s plus with iOS 11.4.1/12 beta 11 and iPad Air with iOS 11.4.1.  The page is not scrolled to top on tapping on status bar in full screen mode.  Looks good.
►

Sign in to add a comment