Location bar animation when getting out of fullscreen is wrong |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Enter fullscreen on any page (2) Exit fullscreen with an action (i.e. tapping the collapsed toolbar, tapping a link on the page) What is the expected result? The animation to get out of fullscreen for the location bar should be smooth. What happens instead? The text is jumping up then is animated down.
,
Aug 29
Gauthier, I tried to fix this and it seems like it's not the location bar's fullscreen handling that's causing the issue. I also think it's not the toolbar, since I tried disabling the toolbar fullscreen handling, and it still exists; but I'm not sure I disabled it fully. If it's not toolbar, I guess it's BVC?
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8600c4494315e658673c9bd2dd76a01f5428e757 commit 8600c4494315e658673c9bd2dd76a01f5428e757 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Aug 31 09:47:27 2018 [iOS] Animate constraints when exiting fullscreen This CL animates the toolbar constraints change when animating the fullscreen final position (i.e. getting out or in). Bug: 876712 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I58dc0c200138f9cf482e9ee25a76e2653665fbfe Reviewed-on: https://chromium-review.googlesource.com/1199063 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587977} [modify] https://crrev.com/8600c4494315e658673c9bd2dd76a01f5428e757/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm
,
Aug 31
,
Oct 1
Verified on 71.0.3567.0 Canary, iPhone X iOS 11.4.1 Looks good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by stkhapugin@chromium.org
, Aug 22