New issue
Advanced search Search tips

Issue 876704 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

CSS: Grid properties should not accept unitless length quirk

Project Member Reported by ericwilligers@chromium.org, Aug 22

Issue description

The following properties are currently accepting unit lengths in quirks mode,
contrary to spec https://quirks.spec.whatwg.org/#the-unitless-length-quirk
- grid-auto-columns
- grid-auto-rows
- grid-template-columns
- grid-template-rows

Safari has the same bug.

 
ConsumeGridBreadth should use
CSSPropertyParserHelpers::UnitlessQuirk::kForbid
instead of
CSSPropertyParserHelpers::UnitlessQuirk::kAllow
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc?q=ConsumeGridBreadth&l=1551&dr=CSs

WPT: The properties should be added to external/wpt/quirks/unitless-length/excluded-properties.html 

Cc: svil...@igalia.com
Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13c023c381d03600b3e2cc525739fa8df6fcc9fe

commit 13c023c381d03600b3e2cc525739fa8df6fcc9fe
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Tue Aug 28 00:11:57 2018

Grid properties should not accept unitless length quirk

The following properties are currently accepting unit lengths
in quirks mode, contrary to spec[1].
- grid-auto-columns
- grid-auto-rows
- grid-template-columns
- grid-template-rows
so it should disallow.

[1]https://quirks.spec.whatwg.org/#the-unitless-length-quirk

Bug:  876704 
Change-Id: I3af3d01f96efb3b3f788ca02893b12c7ae683c20
Reviewed-on: https://chromium-review.googlesource.com/1190045
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586513}
[modify] https://crrev.com/13c023c381d03600b3e2cc525739fa8df6fcc9fe/third_party/WebKit/LayoutTests/external/wpt/quirks/unitless-length/excluded-properties.html
[modify] https://crrev.com/13c023c381d03600b3e2cc525739fa8df6fcc9fe/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc

Owner: hs1217....@samsung.com
Status: Fixed (was: Available)

Sign in to add a comment