Issue metadata
Sign in to add a comment
|
Regression: [NTP] Overlapping between 'Restore default background' text and icon is seen.
Reported by
db...@etouch.net,
Aug 22
|
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3530.0 Revision a20250ff3690485ecc1cfaf289802499a7e611aa-refs/branch-heads/3530@{#1}(64 bit) OS: Mac (10.12.6, 10.13.1,10.13.6, 10.14) Precondition: Enabled 'Enable using the Google local NTP','New Tab Page Background Selection' and 'New Tab Page Custom Links' flags from chrome://flags page. What steps will reproduce the problem? (1) Launch chrome, open NTP and click on 'Gear' icon ('Customise this page' overlay opened) (2) Now press Cmd++ to zoom in page and observe. Actual: Overlapping between 'Restore default background' text and icon is seen. Expected: No such a overlapping should seen. This is a regression, broken in 'M70', below is bisect info: Good Build:70.0.3507.0(Revision:578962) Bad Build: 70.0.3508.0(Revision:579241) You are probably looking for a change made after 578988 (known good), but no later than 578989 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/6f093af4d47dfa53b5bc046602c2c420d5ce3f19..0e19d3a4cfebed8a43abe543b4d6a9092f7e2b8f Suspect: https://chromium.googlesource.com/chromium/src/+/0e19d3a4cfebed8a43abe543b4d6a9092f7e2b8f kristipark@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: This is Mac OS specific issue and same is not reproducible in Windows(7,8,8.1,10) & Linux(14.04 LTS) OS. Thank you.
,
Aug 23
So in fact the behavior we've seen right now is a kind of expected behavior. As we can see in the expected video. If the text is too long for the dialog, it will move down to next row. This is the same behavior as the actual video. However, we add another option that have a long title(restore default shortcuts). They both move down a row. I think a better question is what is the expected behavior for this edge case?
,
Aug 23
I think the menu should probably grow with the zoom. Joel - are there any style guidelines here?
,
Aug 23
I don't know of any guidelines around this. Adding in bettes@ for his POV.
,
Aug 27
Checked with Joel - menu should grow in proportion.
,
Aug 27
,
Aug 28
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/588a27f33655f2d403930eddf3ef0aed5a01a0fe commit 588a27f33655f2d403930eddf3ef0aed5a01a0fe Author: Weilun Shi <sweilun@chromium.org> Date: Wed Aug 29 06:32:42 2018 [NTP] change width for custom background dialog on small window Changing the width of custom background dialog to 232px when the window size is smaller than 356px. The value is decided by the length of the longest option title plus 16px margin on the right. Screenshot: https://screenshot.googleplex.com/iGyXF8Kzesh.png Bug: 876701 Change-Id: I73b8a187110f303a8627271996ff2f5c8881275b Reviewed-on: https://chromium-review.googlesource.com/1192218 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#587025} [modify] https://crrev.com/588a27f33655f2d403930eddf3ef0aed5a01a0fe/chrome/browser/resources/local_ntp/custom_backgrounds.css
,
Aug 29
,
Aug 31
,
Nov 15
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ramyan@google.com
, Aug 22Labels: -Pri-1 Pri-2
Owner: sweilun@chromium.org