https://wicg.github.io/background-fetch/#enumdef-backgroundfetchfailurereason
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f378fd16aff08e8aceb551eaf471ec833a98ffc commit 0f378fd16aff08e8aceb551eaf471ec833a98ffc Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 14:43:03 2018 [Background Fetch] Part 1: Implement BackgroundFetchFailureReason. This is step 1, everything needed to support this on the browser side. Bug: 876691 , 869918 Change-Id: I4c161ae404e24caae9d09b7ea4709a6eb161a95e Reviewed-on: https://chromium-review.googlesource.com/1185006 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#585835} [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch.proto [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_job_controller.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_job_controller.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_test_base.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/background_fetch_test_base.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/create_metadata_task.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/database_helpers.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/database_helpers.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/browser/background_fetch/storage/get_registration_task.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_struct_traits.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_struct_traits.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_struct_traits_unittest.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_types.cc [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/content/common/background_fetch/background_fetch_types.h [modify] https://crrev.com/0f378fd16aff08e8aceb551eaf471ec833a98ffc/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce4238cadf8beec3f37b508d690c84ece793f720 commit ce4238cadf8beec3f37b508d690c84ece793f720 Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 16:13:53 2018 [Background Fetch] Update Background Fetch unit tests. Now that we're passing BackgroundFetchRegistration with all BackgroundFetch Events, the unit tests can be simplified. Bug: 876691 , 869918 Change-Id: I5137981b32666901cdc6f953b744372695b11d72 Reviewed-on: https://chromium-review.googlesource.com/1186722 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585861} [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.h [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_event_dispatcher_unittest.cc [modify] https://crrev.com/ce4238cadf8beec3f37b508d690c84ece793f720/content/browser/background_fetch/background_fetch_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9daf4f57c080e9835db640bb8ea532623782c1ac commit 9daf4f57c080e9835db640bb8ea532623782c1ac Author: Mugdha Lakhani <nator@chromium.org> Date: Fri Aug 24 18:08:35 2018 [BackgroundFetch] Part 2: Implement BackgroundFetchFailureReason. This is the second part, the plumbing on the blink side. Bug: 876691 , 869918 Change-Id: I62fe4aaf37f41b5ebd341ce4731f7fda1d486feb Reviewed-on: https://chromium-review.googlesource.com/1185015 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585906} [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/get.https.window.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.sharedworker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/idlharness.https.any.worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw-helpers.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw.js [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/public/platform/modules/background_fetch/web_background_fetch_registration.h [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.h [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.idl [modify] https://crrev.com/9daf4f57c080e9835db640bb8ea532623782c1ac/third_party/blink/renderer/modules/background_fetch/background_fetch_type_converters.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f commit 87e06f7bb0df493cc8dcd8227e69450a5e7aee5f Author: Mugdha Lakhani <nator@chromium.org> Date: Wed Sep 05 10:33:19 2018 [Background Fetch] Deprecate BackgroundFetchReasonToAbort in favor of blink::mojom::BackgroundFetchFailureReason. Bug: 876691 Change-Id: I147c5b669adf4b35c58633b1068e83bf4a0e4351 Reviewed-on: https://chromium-review.googlesource.com/1204231 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#588820} [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/chrome/browser/DEPS [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_delegate_proxy.cc [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_delegate_proxy.h [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_job_controller.cc [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_job_controller.h [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_job_controller_unittest.cc [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_scheduler.cc [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/browser/background_fetch/background_fetch_scheduler.h [modify] https://crrev.com/87e06f7bb0df493cc8dcd8227e69450a5e7aee5f/content/public/browser/background_fetch_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19acd967d6a3a3c67aa36b88023a2b47d01e4042 commit 19acd967d6a3a3c67aa36b88023a2b47d01e4042 Author: Mugdha Lakhani <nator@chromium.org> Date: Thu Sep 20 16:52:09 2018 [Background Fetch] Set bad-status as failureReason when one of the settled fetches has a response with a bad status. Bug: 876691 Change-Id: I45af6b792a6a43e5b091bc5fe6f40d011bdabac5 Reviewed-on: https://chromium-review.googlesource.com/1233693 Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592836} [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/content/browser/background_fetch/background_fetch_context.cc [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/content/browser/background_fetch/background_fetch_context.h [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/content/browser/background_fetch/background_fetch_data_manager.h [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/content/browser/background_fetch/background_fetch_data_manager_unittest.cc [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/content/browser/background_fetch/storage/get_settled_fetches_task.cc [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/content/browser/background_fetch/storage/get_settled_fetches_task.h [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window-expected.txt [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js [modify] https://crrev.com/19acd967d6a3a3c67aa36b88023a2b47d01e4042/third_party/WebKit/LayoutTests/external/wpt/background-fetch/service_workers/sw.js
Comment 1 by bugdroid1@chromium.org
, Aug 24