Regression: Bookmark Bar appears blank after removing bookmark in Incognito window
Reported by
khushal....@etouch.net,
Aug 22
|
||||
Issue descriptionChrome Version: 70.0.3530.0 (Official Build) Revision a20250ff3690485ecc1cfaf289802499a7e611aa-refs/branch-heads/3530@{#1} (64 bit) OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch Google Chrome, open 'New Incognito Window' and bookmark NTP of Incognito mode. (2) Now Remove bookmark and Observe Bookmark Bar. Actual Result: Bookmark Bar appears blank after removing bookmark. Expected Result: Bookmark Bar should appear with the content "Import Bookmarks now.." after removing bookmark. This is a Regression issue seen from 'M-70' and provide the bisect info soon: Good Build: 70.0.3528.0 (Revision: 584350) Bad Build: 70.0.3529.0 (Revision: 584585)
,
Aug 22
FYI for further investigation: CMD-B or CMD-T fixes the issue. I also noticed that the favicon of the first saved Bookmark is clipped in Incognito Mode's Bookmarks Bar. Also in this case, CMD-B or CMD-T or saving a second Bookmark fixes the issue.
,
Aug 22
Further information: This is not only Incognito-related. It also happens in normal windows, when the Appstore Default Bookmark is deactivated (via right-click context menu). BTW: Sorry, in comment 2 I meant SHIFT-CMD-B (and not CMD-B) A screencast is attached which showing the missing text and the clipped favicon in normal window.
,
Aug 22
One more information :) In normal window, if you have the default App Store Bookmark deactivated and you quit and relaunch Chrome, the Bookmarks Bar becomes also blank. I noticed that resizing the window also fixes the issue.
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9 commit 2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9 Author: Charlene Yan <cyan@chromium.org> Date: Thu Aug 30 18:20:16 2018 Fixing the height of the bookmark bar and buttons on the bookmark bar. Bug: 876690 , 876682 , 879154 Change-Id: Ia72f26e9d7e0402868dd628fa2e10492b46a2cee Reviewed-on: https://chromium-review.googlesource.com/1194728 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587664} [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/layout_constants.cc [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/layout_constants.h [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/2cbdecbb3f8f5b16a6a0745d0f16df9ead44d6e9/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
,
Aug 31
Update: Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) using latest canary version #70.0.3538.0 and the issue is found FIXED. Hence, adding the respective labels. Please refer the attached screen-cast. Thank You..!!
,
Sep 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by khushal....@etouch.net
, Aug 22Owner: cyan@chromium.org
Status: Assigned (was: Unconfirmed)