Regression:New shortcuts are not created on NTP after removing existing shortcuts
Reported by
vineetha...@etouch.net,
Aug 22
|
|||||
Issue descriptionChrome Version: 70.0.3530.0 (Official Build) Revision a20250ff3690485ecc1cfaf289802499a7e611aa-refs/branch-heads/3530@{#1}(32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04) Pre-condition: Enable 'Enable using the Google local NTP' and 'New Tab Page Custom Links' under chrome://flags. What steps will reproduce the problem? (1) Launch Chrome and enable above mentioned flags, then visit any website. (2) Open NTP and observe that the shortcut for visited website is available along with Chrome Webstore shortcut and 'Add Shortcut' button. (3) Click on the three dot icon for all the added shortcuts(including Chrome webstore shortcut) and click on 'Remove button'. (4) Now visit any other website and again open new NTP and observe. Actual Result : After removing existing shortcuts new shortcuts are not created on NTP. Expected Result: Shortcuts should be created on NTP even after removing existing shortcuts. This is a regression issue, broken in 'M-70', and below is per-revision bisect-info: Good Build: 70.0.3503.0 (Revision:578160) Bad Build : 70.0.3504.0 (Revision:578510) You are probably looking for a change made after 578403 (known good), but no later than 578404 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/cc26ae0530e932f65dbab9bccbf5f590a9d37c94..c7c6a230da8a075b37f7306f4f8902e7a3f3b490 Suspect: https://chromium.googlesource.com/chromium/src/+/c7c6a230da8a075b37f7306f4f8902e7a3f3b490 @kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly review the attached screen-cast . Thank You!
,
Aug 22
It's WAI - if shortcuts are removed on the NTP, it affects the list of shortcuts visible on future NTPs. ie. the user has indicated they do not want those shortcuts, so we don't show them again.
,
Aug 23
Update w.r.t comment#2 : Pardon me if it was an intended behaviour but just to add my observation, if user is navigating to a valid URL 'A'(e.g: www.gmail.com) , a shortcut for A gets created on NTP . Now, user removes the shortcut for A and visits another valid URL 'B'(e.g: www.youtube.com) then observe that after navigating on NTP the shortcut for URL 'B' is not created. Kindly refer attached screencast showing the above scenario.
,
Aug 23
kristipark@/ ramyan@ -- Could you please take a look into C#3. Please close if it is still the intended behavior. Thanks!
,
Aug 23
What's happening is that by removing the GMail link, the user has modified their default shortcuts (ie their most visited sites) - at this point, the gear menu would show "Restore default shortcuts" as clickable. Subsequent items that would have shown up as most visited do not appear in the list unless "Restore default shortcuts is selected". In fact, the Youtube (and Gmail) icons should show up if you do that at the end of the screencast. +Yana & Joel FYI.
,
Aug 23
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nyerramilli@chromium.org
, Aug 22Labels: ReleaseBlock-Stable