Issue metadata
Sign in to add a comment
|
Regression : Unnecessarily 'Cast' icon shifts to LHS after dragging it in wrench menu.
Reported by
rp...@etouch.net,
Aug 22
|
||||||||||||||||||||||
Issue descriptionChrome version: 70.0.3530.0 (Official Build)Revision a20250ff3690485ecc1cfaf289802499a7e611aa-refs/branch-heads/3530@{#1}(32/64-bit) OS: Windows 10 What steps will reproduce the problem? 1. Launch chrome,navigate to NTP open right click context menu and select cast option. 2. Now right click on cast icon in omnibox and select 'Always show icon' and drag it to hide in chrome menu 3. Now click on 'Customize and control Google Chrome' and drag cast icon to LHS in wrench menu,observe Actual: Unnecessarily 'Cast' icon shifts to LHS after dragging it in wrench menu Expected: 'Cast' icon should not shift to LHS after dragging it in wrench menu This is regression issue, broken in ‘M 70’ and will soon update other info : Good build: 70.0.3516.0 (Revision: 581410). Bad build: 70.0.3517.0 (Revision: 581729). You are probably looking for a change made after 581631 (known good), but no later than 581642 (first known bad). Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/7e19e900c9d1b48baca21a11b750d53b380da492..58d0ec05472bf1fa3b3ad9caaeae5ca49a065b86?pretty=fuller&n=50 Suspecting: https://chromium.googlesource.com/chromium/src/+/da1724ca73e328bdafe26040eb170daf526549bc from Narrow bisect @tbergquist: Could you please help to reassign if your change is not the cause for this change. Note: 1.Unable to provide bisect using per-revision script,Hence providing chromium bisect. 2.Issue is not seen on Windows (7,8,8.1),Mac(10.12.6,10.13.1,10.13.6)& Linux (14.04 LTS)OS
,
Aug 22
Your suspicion appears to be correct, and in progress CL https://crrev.com/c/1176824 fixes it.
,
Aug 22
Also, this only happens when the window is maximized, and only with the first drag operation. The second drag fixes everything. The first drag will cause the dropdown menu to shift/shrink slightly to the right even if it's a normal drag and drop (i.e. if it's within the bounds of the container).
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15633635ae43e020478d15dee584d7761beb0428 commit 15633635ae43e020478d15dee584d7761beb0428 Author: Taylor Bergquist <tbergquist@chromium.org> Date: Thu Aug 23 02:34:27 2018 Include non-resize-handle border in frame insets. https://crrev.com/c/1149273 used a new Windows API, GetSystemMetricsForDpi, to better handle multi-monitor high DPI frame sizing scenarios. However this API does not perpetuate a backwards- compatibility behavior we were relying on before, where SM_CXSIZEFRAME would include the non-resize-handle border space, SM_CXPADDEDBORDER, (added in Vista) in addition to the resize handle space. As a result, we weren't accounting for that border space when calculating client area insets. This CL includes that space explicitly. Bug: 873860 Bug: 874884 Bug: 876687 Change-Id: I19a9bde9c684e801cefb5f98162dba64ece295af Reviewed-on: https://chromium-review.googlesource.com/1176824 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#585374} [modify] https://crrev.com/15633635ae43e020478d15dee584d7761beb0428/chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc [modify] https://crrev.com/15633635ae43e020478d15dee584d7761beb0428/chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc [modify] https://crrev.com/15633635ae43e020478d15dee584d7761beb0428/ui/base/BUILD.gn [add] https://crrev.com/15633635ae43e020478d15dee584d7761beb0428/ui/base/win/hwnd_metrics.cc [add] https://crrev.com/15633635ae43e020478d15dee584d7761beb0428/ui/base/win/hwnd_metrics.h [modify] https://crrev.com/15633635ae43e020478d15dee584d7761beb0428/ui/views/win/hwnd_message_handler.cc
,
Aug 23
,
Aug 24
Update : Rechecked the above issue on Windows 10 OS with latest Canary Chrome version : 70.0.3532.0 and the issue is Fixed.Hence adding TE Verified Label. Kindly refer the attached screen cast for reference. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Aug 22