New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876681 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 877231



Sign in to add a comment

'websocket._exceptions.WebSocketTimeoutException is interrupt the whole benchmark run

Project Member Reported by nednguyen@chromium.org, Aug 22

Issue description

See log: 
https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=fbdb43a61c23c2e00ed011c147d38c2479bf27cb&as=blink_perf.css%5Cbenchmark_log.txt

From build https://ci.chromium.org/buildbot/chromium.perf/win-10-perf/316

This is another case of a handleable error interrupt the whole benchmark run. Will convert/wrap this error with Telemetry core.exceptions.Error
 
Cc: kbr@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c

commit a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c
Author: Nghia Nguyen <nednguyen@google.com>
Date: Thu Aug 23 14:39:21 2018

Wrap all exception of websocket with telemetry's exception.Error for recoverability

Telemetry benchmark loop divides exceptions which are raised during benchmark run into two types:
recoverable & unrecoverable. All the exception of type telemetry.core.exceptions.Error are recoverable
according the Telemetry benchmark loop.

Before this CL, every client that use chrome_inspector.inspector_websocket.InspectorWebsocket is responsible
for converting the exceptions of websocket library (third party) to recoverable Telemetry exception. This can be
error prone, as attached bug is one of the case one client forget to convert a websocket error to recoverable Telemetry exception, thus
make error in devtool connection on one benchmark test killing the whole benchmark run.

With this CL, we make sure that chrome_inspector.inspector_websocket.InspectorWebsocket only raises recoverable Telemetry exception for
all error related to websocket connection.

Note: this CL also disables pinpoint.handlers.migrate_test.MigrateTest.testJobsMigrated ( crbug.com/877074 )

Bug:  chromium:876681 ,  chromium:877074 
Change-Id: Ic641a3b74ca21fca22c9e615135493af2bdcbdd4

TBR=dtu@chromium.org  # Pinpoint test disabling

Change-Id: Ic641a3b74ca21fca22c9e615135493af2bdcbdd4
Reviewed-on: https://chromium-review.googlesource.com/1184974
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/memory_backend.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_memory.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket_unittest.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/dashboard/dashboard/pinpoint/handlers/migrate_test.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/a7fb87b3a3d1dde21cc2cb1e0fd10e6c3bf3496c/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/790625b3d4eb276334589f4e0e3a0f3adf8a8262

commit 790625b3d4eb276334589f4e0e3a0f3adf8a8262
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 23 15:49:23 2018

Roll src/third_party/catapult 2229a8947448..a7fb87b3a3d1 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/2229a8947448..a7fb87b3a3d1


git log 2229a8947448..a7fb87b3a3d1 --date=short --no-merges --format='%ad %ae %s'
2018-08-23 nednguyen@google.com Wrap all exception of websocket with telemetry's exception.Error for recoverability


Created with:
  gclient setdep -r src/third_party/catapult@a7fb87b3a3d1

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:876681 , chromium:877074 
TBR=sullivan@chromium.org

Change-Id: I71fcf38964d1c2bde5afaea5d789314b35724b0e
Reviewed-on: https://chromium-review.googlesource.com/1186664
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585496}
[modify] https://crrev.com/790625b3d4eb276334589f4e0e3a0f3adf8a8262/DEPS

Status: Fixed (was: Started)
Should be fixed
Blocking: 877231
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/0ec78800bede9fe0b775798b969f7292d538f82d

commit 0ec78800bede9fe0b775798b969f7292d538f82d
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Oct 16 13:13:39 2018

[telemetry] Fix typo in WebSocketException

WebsocketException -> WebSocketException

Bug:  chromium:876681 
Change-Id: I414e875bb5eeb7d5d689b423c07cc4dcbfff750f
Reviewed-on: https://chromium-review.googlesource.com/c/1283269
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/0ec78800bede9fe0b775798b969f7292d538f82d/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py
[modify] https://crrev.com/0ec78800bede9fe0b775798b969f7292d538f82d/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc94ed5cffd4b545d9cf935c8cb7d32d8812072

commit 0fc94ed5cffd4b545d9cf935c8cb7d32d8812072
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 16 22:07:18 2018

Roll src/third_party/catapult 88afab4ff0f0..b273e0cd217d (3 commits)

https://chromium.googlesource.com/catapult.git/+log/88afab4ff0f0..b273e0cd217d


git log 88afab4ff0f0..b273e0cd217d --date=short --no-merges --format='%ad %ae %s'
2018-10-16 lwsong@google.com Add aggregate graphs to visualization tool.
2018-10-16 perezju@chromium.org [telemetry] Fix typo in WebSocketException
2018-10-16 perezju@chromium.org [soundwave] Remove old comment


Created with:
  gclient setdep -r src/third_party/catapult@b273e0cd217d

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:876681 
TBR=sullivan@chromium.org

Change-Id: I5fdc43203e194660ce62571123e9f8003626dfc1
Reviewed-on: https://chromium-review.googlesource.com/c/1284569
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600147}
[modify] https://crrev.com/0fc94ed5cffd4b545d9cf935c8cb7d32d8812072/DEPS

Sign in to add a comment