New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876679 link

Starred by 1 user
Status: WontFix
Owner:
puthik@chromium.org
Closed: Aug 23
Cc:
mqg@chromium.org
█ seankao@google.com
tbroch@chromium.org
coconutruben@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Power dashboard 'timestamp' field records wrong time. It's not the time when the test start running.

Project Member Reported by seankao@google.com, Aug 22 
In client/cros/power/power_dashboard.py, 'timestamp' field records the time when _create_powerlog_dict is called. And _create_powerlog_dict is called in upload, which is (usually) called at the end of a test.
According to go/power-dashboard-doc, this field should record the unix timestamp when the test start running.

Comment 1 by coconutruben@chromium.org, Aug 22 

Opal, could we do something like
- redefining _create_powerlog_dict in the MeasurementLogger class and replacing timestamp with the first timestamp in the logger
- requiring that init sets a self._timestamp and then have _create_powerlog_dict depend on that?

If there are no concerns with either I can push a WIP

https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/client/cros/power/power_dashboard.py#272

Comment 2 by puthik@chromium.org, Aug 23

Status: WontFix (was: Assigned)
We actually don't care about timestamp field represent time when test start running or finish running.

I think it is better to just change doc to make 'timestamp' records time when test finish running because the existing data will be correct.

Comment 3 by coconutruben@chromium.org, Aug 24 

Fair enough, in that case Sean's checkpoint data will have the be converted to relative time from the start when uploading it to the dashboard.
►

Sign in to add a comment