New issue
Advanced search Search tips

Issue 876664 link

Starred by 1 user
Status: Fixed
Owner:
hkamila@chromium.org
Closed: Aug 29
Cc:
hkamila@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

GetPatternsFromScopingType() is untested

Project Member Reported by msramek@chromium.org, Aug 22 
HostContentSettingsMap::GetPatternsFromScopingType() contains logic to determine the [primary, secondary] based on the content setting's scoping type when a new setting is to be added for an origin.

It appears that this logic is untested.

Comment 1 by msramek@chromium.org, Aug 22

Labels: -OS-iOS

Comment 2 by hkamila@chromium.org, Aug 27

Owner: hkamila@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489cc29c6e636ed2a68e82d6dd481cab5c0ae548

commit 489cc29c6e636ed2a68e82d6dd481cab5c0ae548
Author: Kamila <hkamila@google.com>
Date: Wed Aug 29 14:05:58 2018

Added unittest for GetPatternsScopingType

- Created unittest for testing the logic of GetPatternsScopingType.

Bug:  876664 
Change-Id: Id320a0783c65466dbe7d08545a60ac1489762d8d
Reviewed-on: https://chromium-review.googlesource.com/1189944
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587099}
[modify] https://crrev.com/489cc29c6e636ed2a68e82d6dd481cab5c0ae548/chrome/browser/content_settings/host_content_settings_map_unittest.cc

Comment 4 by hkamila@chromium.org, Aug 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment