Grey focus highlight is not seen on 'Chrome name and picture' arrow icon in chrome://settings page.
Reported by
rp...@etouch.net,
Aug 22
|
||||||
Issue descriptionChrome Version: 70.0.3530.0 (Official Build)Revision a20250ff3690485ecc1cfaf289802499a7e611aa-refs/branch-heads/3530@{#1}(32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04 LTs). What steps will reproduce the problem? 1. Launch Chrome and navigate to chrome://settings 2. Now press 'Tab' key to bring focus on 'Chrome name and picture' arrow icon and press 'Space bar' key 3. Now again press 'Space bar' key and observe 'Chrome name and picture' arrow icon Actual: Grey focus highlight is not seen on 'Chrome name and picture' arrow icon Expected: Grey focus highlight should be seen on 'Chrome name and picture' arrow icon This is a non-regression issue, seen from M-70 series as 'Chrome name and picture' is introduced from build #70.0.3526.0 NOTE: This issue is also reproducible on Dev #70.0.3528.4 Kindly review the attached screen-cast for reference. Thank you.
,
Oct 3
Did a bisect and landed on https://chromium.googlesource.com/chromium/src/+log/0c59f5988813ba200eaeee3f39a5f68c32917f26..a82f941966a82c1dd9d3b192b94355c0531df116 Suspecting that this was always broken for DICE, which was enabled at r569640. @droger can you take a look, or forward to the appropriate person?
,
Oct 3
That CL is the one that enabled Dice, and so made the switch from the old settings page to the new. The problem is not caused by this CL directly, it's just a bug in the new settings page. Tentatively assigning to scottchen, maybe he wrote this code?
,
Oct 3
I have a candidate fix for this.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0748479ff507aac6b1af09ce7138b96ee6327085 commit 0748479ff507aac6b1af09ce7138b96ee6327085 Author: dpapad <dpapad@chromium.org> Date: Fri Oct 05 00:06:49 2018 Settings WebUI: Fix focus restoration when exiting /manageProfile. The code still accomodates both the DICE and non-DICE cases, which makes it complicated. Hopefully the non-DICE code can be removed soon. Bug: 876661 Change-Id: I7b457dd79aa4ce88fa301fda9c8f6894d64fa99b Reviewed-on: https://chromium-review.googlesource.com/c/1258091 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596932} [modify] https://crrev.com/0748479ff507aac6b1af09ce7138b96ee6327085/chrome/browser/resources/settings/people_page/people_page.js
,
Oct 5
,
Oct 5
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14.1) using latest Canary build : 71.0.3571.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!!
,
Oct 9
Issue 875765 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nyerramilli@chromium.org
, Aug 22