New issue
Advanced search Search tips

Issue 876660 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CRAS: can not log events to UMA

Project Member Reported by yuhsuan@chromium.org, Aug 22

Issue description

We can't send events from CRAS to UMA now. It's because we don't init CMetricsLibrary object in crrev.com/c/1163645 .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/10207c976e4f2cd0c7bf50c0889f41259d773d51

commit 10207c976e4f2cd0c7bf50c0889f41259d773d51
Author: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Date: Fri Aug 24 06:27:56 2018

CRAS: metrics - Init metric handle to let CRAS send events to UMA

We need to call CMetricsLibraryInit function first so that it can
send events successfully.

BUG= chromium:876660 
TEST=verify events and samples can be sent to UMA.

Change-Id: I49d0d636d68c83de00292673c3f649fc6222b3df
Reviewed-on: https://chromium-review.googlesource.com/1184806
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/10207c976e4f2cd0c7bf50c0889f41259d773d51/cras/src/common/cras_metrics.c

Labels: Merge-Request-69
The change fixed the bug which was merged in M69. So request merge to M69, too. Thanks.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 24

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
The cheery-pick link: crrev.com/c/1188216
It is a pretty small change for initializing metric handle in CRAS. It is safe and won't break anything.
Labels: -Merge-Review-69
Status: Fixed (was: Untriaged)
Thanks yuhsuan@ for the fix.

And turns out we don't need this be in M69 anymore.

Sign in to add a comment