New issue
Advanced search Search tips

Issue 876658 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

SocketApiTest.GetNetworkList failing on chromium.memory/win-asan

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 22

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yosin@chromium.org

SocketApiTest.GetNetworkList failing on chromium.memory/win-asan

Builders failed on: 
- win-asan: 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/1069

[ RUN      ] SocketApiTest.GetNetworkList
DevTools listening on ws://127.0.0.1:50086/devtools/browser/1fb1f235-55be-48cf-95f7-d87158d029f7
=================================================================
==440==ERROR: AddressSanitizer: access-violation on unknown address 0x000000000000 (pc 0x7ff7a015f46b bp 0x00e442cfebb0 sp 0x00e442cfeaa0 T2)
==440==The signal is caused by a READ memory access.
==440==Hint: address points to the zero page.
==440==*** WARNING: Failed to initialize DbgHelp!              ***
==440==*** Most likely this means that the app is already      ***
==440==*** using DbgHelp, possibly with incompatible flags.    ***
==440==*** Due to technical reasons, symbolization might crash ***
==440==*** or produce wrong results.                           ***
    #0 0x7ff7a015f46a in extensions::ExtensionWebRequestEventRouter::ExtensionWebRequestEventRouter C:\b\swarming\w\ir\cache\builder\src\extensions\browser\api\web_request\web_request_api.cc:850
    #1 0x7ff7a015c7cb in extensions::ExtensionWebRequestEventRouter::GetInstance C:\b\swarming\w\ir\cache\builder\src\extensions\browser\api\web_request\web_request_api.cc:843
    #2 0x7ff79ff3338e in extensions::`anonymous namespace'::RegisterToExtensionWebRequestEventRouterOnIO C:\b\swarming\w\ir\cache\builder\src\extensions\browser\api\declarative\rules_registry_service.cc:35
    #3 0x7ff79ff39e28 in base::internal::Invoker<base::internal::BindState<void (*)(content::BrowserContext *, int, scoped_refptr<extensions::WebRequestRulesRegistry>),content::BrowserContext *,int,scoped_refptr<extensions::WebRequestRulesRegistry> >,void ()>::Run C:\b\swarming\w\ir\cache\builder\src\base\bind_internal.h:671
    #4 0x7ff7a511a7dd in base::debug::TaskAnnotator::RunTask C:\b\swarming\w\ir\cache\builder\src\base\debug\task_annotator.cc:101
    #5 0x7ff7a2bb10c8 in base::MessageLoop::RunTask C:\b\swarming\w\ir\cache\builder\src\base\message_loop\message_loop.cc:434
    #6 0x7ff7a2bb1fbf in base::MessageLoop::DoWork C:\b\swarming\w\ir\cache\builder\src\base\message_loop\message_loop.cc:517
    #7 0x7ff7a2bb8da2 in base::MessagePumpForIO::DoRunLoop C:\b\swarming\w\ir\cache\builder\src\base\message_loop\message_pump_win.cc:494
    #8 0x7ff7a2bb51fb in base::MessagePumpWin::Run C:\b\swarming\w\ir\cache\builder\src\base\message_loop\message_pump_win.cc:52
    #9 0x7ff7a2c1e144 in base::RunLoop::Run C:\b\swarming\w\ir\cache\builder\src\base\run_loop.cc:102
    #10 0x7ff79e8a476c in content::BrowserProcessSubThread::IOThreadRun C:\b\swarming\w\ir\cache\builder\src\content\browser\browser_process_sub_thread.cc:175
    #11 0x7ff7a2cad52c in base::Thread::ThreadMain C:\b\swarming\w\ir\cache\builder\src\base\threading\thread.cc:357
    #12 0x7ff7a2ca8cdf in base::`anonymous namespace'::ThreadFunc C:\b\swarming\w\ir\cache\builder\src\base\threading\platform_thread_win.cc:91
    #13 0x7ff7a2ab6e98 in __asan::AsanThread::ThreadStart C:\b\rr\tmpwi75sb\w\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_thread.cc:262
    #14 0x7ffa079e2773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #15 0x7ffa080b0d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: access-violation C:\b\swarming\w\ir\cache\builder\src\extensions\browser\api\web_request\web_request_api.cc:850 in extensions::ExtensionWebRequestEventRouter::ExtensionWebRequestEventRouter
Thread T2 created by T0 here:
    #0 0x7ff7a2ab5d10 in __asan_wrap_CreateThread C:\b\rr\tmpwi75sb\w\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_win.cc:146
    #1 0x7ff7a2ca82db in base::`anonymous namespace'::CreateThreadInternal C:\b\swarming\w\ir\cache\builder\src\base\threading\platform_thread_win.cc:130
    #2 0x7ff7a2cac517 in base::Thread::StartWithOptions C:\b\swarming\w\ir\cache\builder\src\base\threading\thread.cc:119
    #3 0x7ff79e8a3ef7 in content::BrowserProcessSubThread::CreateIOThread C:\b\swarming\w\ir\cache\builder\src\content\browser\browser_process_sub_thread.cc:90
    #4 0x7ff7a02475e0 in content::ContentMainRunnerImpl::Run C:\b\swarming\w\ir\cache\builder\src\content\app\content_main_runner_impl.cc:868
    #5 0x7ff7a3d388f6 in service_manager::Main C:\b\swarming\w\ir\cache\builder\src\services\service_manager\embedder\main.cc:472
    #6 0x7ff7a024582c in content::ContentMain C:\b\swarming\w\ir\cache\builder\src\content\app\content_main.cc:19
    #7 0x7ff7a43401d6 in content::BrowserTestBase::SetUp C:\b\swarming\w\ir\cache\builder\src\content\public\test\browser_test_base.cc:322
    #8 0x7ff79c1cd01b in extensions::AppShellTest::SetUp C:\b\swarming\w\ir\cache\builder\src\extensions\shell\test\shell_test.cc:31
    #9 0x7ff7a022124e in testing::Test::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2502
    #10 0x7ff7a0222536 in testing::TestInfo::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2682
    #11 0x7ff7a02235d5 in testing::TestCase::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:2800
    #12 0x7ff7a023b0a9 in testing::internal::UnitTestImpl::RunAllTests C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:5124
    #13 0x7ff7a023a5f1 in testing::UnitTest::Run C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:4733
    #14 0x7ff7a435a505 in base::TestSuite::Run C:\b\swarming\w\ir\cache\builder\src\base\test\test_suite.cc:277
    #15 0x7ff79c1cd43b in extensions::AppShellTestLauncherDelegate::RunTestSuite C:\b\swarming\w\ir\cache\builder\src\extensions\shell\test\shell_test_launcher_delegate.cc:15
    #16 0x7ff7a43522af in content::LaunchTests C:\b\swarming\w\ir\cache\builder\src\content\public\test\test_launcher.cc:645
    #17 0x7ff79c1cd7f7 in main C:\b\swarming\w\ir\cache\builder\src\extensions\shell\test\shell_tests_main.cc:17
    #18 0x7ff7ad9e9e27 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    #19 0x7ffa079e2773 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180012773)
    #20 0x7ffa080b0d50 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x180070d50)
==440==ABORTING


 
Owner: dhnishi@chromium.org
Status: Assigned (was: Available)
dhnishi@, since you're the author of the test, could you take look?
Owner: yosin@chromium.org
ihavenomemoryofthisplace.jpg

I didn't author the test, but I did move it back in 2014 when I worked as a software contractor outside of Google.

Anyway, I don't work on Chromium anymore, so this should probably go to someone else.
Owner: ----
Status: Available (was: Assigned)
Labels: Sheriff-Chromium
Status: Untriaged (was: Available)
Back to sheriff queue to assign to appropriate person.
Components: Platform>Extensions
Cc: karandeepb@chromium.org rdevlin....@chromium.org benwells@chromium.org lazyboy@chromium.org
Adding several OWNERs of //extensions for triage.
Cc: roc...@chromium.org
Components: -Platform>Extensions Platform>Apps
Owner: reillyg@chromium.org
Status: Assigned (was: Untriaged)
Triage!  reillyg@ and rockot@ are owners of the sockets API.
Labels: -Sheriff-Chromium
Removing from the Sheriff queue, as this is properly triaged.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2698b3e236d13ccbce2fc1a9bc502327d7ffd3ba

commit 2698b3e236d13ccbce2fc1a9bc502327d7ffd3ba
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Sep 07 18:01:32 2018

Add DCHECK to catch missing ExtensionsAPIClient

This change adds a DCHECK to the ExtensionWebRequestEventRouter
constructor in order to catch when there is no ExtensionsAPIClient
set for the process. This appears to be the cause of issue 876658
where an unrelated test fails due to asynchronous initialization
of the ExtensionWebRequestEventRouter triggering a null pointer
dereference.

Adding this DCHECK will confirm that this is the cause of the
crash. It is still unclear why the ExtensionsAPIClient would be
unconfigured in a browser test.

Bug: 876658
Change-Id: I55deefd3a94046cfa30ba37f65593914e2dc974e
Reviewed-on: https://chromium-review.googlesource.com/1213276
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589580}
[modify] https://crrev.com/2698b3e236d13ccbce2fc1a9bc502327d7ffd3ba/extensions/browser/api/web_request/web_request_api.cc

Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment