New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876643 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 897147



Sign in to add a comment

Relaunch Notification doesn't work on rollback.

Project Member Reported by fane@google.com, Aug 22

Issue description

Chrome Version: 70.0.3530.0 (Developer Build)
OS: Chrome OS

What steps will reproduce the problem?
(1) Set RelaunchNotification policy to recommended (1) or required (2).
(2) Rollback the device (downgrade to a previous version of Chrome OS).

What is the expected result?

A notification telling the user their admin is asking/requiring them to restart their device in order to complete the update.
If policy is set to 2, the device will restart no matter what on a specified deadline.

What happens instead?

A rollback notification shows up, telling the user that their device is being rolled back, but doesn't inform them about the relaunch policy which will restart their device if set to required (2).


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
I have rolled back a device with the RelaunchNotification policy set to 2 (required) and I got the notification title "Restart Chromium OS within 4 days" but the notification body "Your administrator is rolling back your device. All data will be deleted when the device is restarted."

This is happening because, in this file:
https://cs.chromium.org/chromium/src/ash/system/update/update_notification_controller.cc?dr=CSs&sq=package:chromium&g=0&l=94

In GetNotificationMessage(), rollback takes precedence over the custom notification_body sent by relaunch notification.
In GetNotificationTitle() it's the other way around
Cc: hunyadym@chromium.org zentaro@chromium.org
Owner: poromov@chromium.org
Cc: raleksandrov@google.com
Blocking: 897147
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment